From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com
 [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id 31C47B38D
 for <dev@dpdk.org>; Thu, 18 Jun 2015 09:07:02 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id t5I76oXR026814;
 Thu, 18 Jun 2015 00:06:51 -0700
Date: Thu, 18 Jun 2015 12:36:00 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150618070557.GA19045@scalar.blr.asicdesigners.com>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <cover.1433164517.git.rahul.lakkireddy@chelsio.com>
 <2e5139b0b03cdd49ad41feb8d3747d6d10f35255.1433164517.git.rahul.lakkireddy@chelsio.com>
 <4065601.TTgiMRsfyC@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4065601.TTgiMRsfyC@xps13>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 07:07:02 -0000

Hi Thomas,

On Wed, Jun 17, 2015 at 14:30:55 +0200, Thomas Monjalon wrote:
> It doesn't build as a shared library.
> Please add EXPORT_MAP and LIBABIVER to the Makefile.

Will fix this in v3.

> It would be easier to test if build config was merged in this patch,
> with the Makefile.
> 
> Please merge also the maintainer infos.
> 

Will merge build config and maintainers with the Makefile patch

> 2015-06-01 23:00, Rahul Lakkireddy:
> > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))
> 
> RTE_DIM may be used

Will fix this in v3.

Thanks,
Rahul