From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <cchemparathy@ezchip.com> Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0093.outbound.protection.outlook.com [157.56.112.93]) by dpdk.org (Postfix) with ESMTP id A1DC8C67A for <dev@dpdk.org>; Mon, 22 Jun 2015 22:35:04 +0200 (CEST) Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none; Received: from cchemparathy-ubuntu (12.218.212.162) by AM2PR02MB0787.eurprd02.prod.outlook.com (10.163.146.19) with Microsoft SMTP Server (TLS) id 15.1.195.15; Mon, 22 Jun 2015 20:35:02 +0000 Date: Mon, 22 Jun 2015 13:34:46 -0700 From: Cyril Chemparathy <cchemparathy@ezchip.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Message-ID: <20150622133446.0df0b07f@cchemparathy-ubuntu> In-Reply-To: <29909138.qD9kMyzFYN@xps13> References: <1433516110-11468-1-git-send-email-danielx.t.mrzyglod@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912632371E3A@IRSMSX108.ger.corp.intel.com> <29909138.qD9kMyzFYN@xps13> Organization: EZchip X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [12.218.212.162] X-ClientProxiedBy: CO1PR06CA026.namprd06.prod.outlook.com (10.242.160.16) To AM2PR02MB0787.eurprd02.prod.outlook.com (25.163.146.19) X-Microsoft-Exchange-Diagnostics: 1; AM2PR02MB0787; 2:Obv9oFK6tSivcnGyTk6zOISxYyeMBM1DZcdKLxTbHCf8TG00tKD3GhRsb7s5RNXE; 3:pf39+03Rt4SUcLjcynwov96jhvMqmJncyidFwW6p0/ee0M150wftdJWucc2CjY5l3O2nUoJjyQpFWDPsBt4duWH7Z9rOPJPhbVG/0f5+B94sqgYZTV0UWEoh4aWH/LTpmgjCGHZjIyB16hrV1Lqcuw==; 20:HPHvtCHnWv8KGr/00qY4NQ9pgp9MslE81BXLAmJwcRj2aupvT5yHDRbkhCzOXl+O7dfiCsMU1cdenSedwM4Fyer7PQyalYSdmTsQk5ynWb4a9rBSEh5AZhA+36tvhtecrJt3aU+7GuisG04iXtEE/SFXe2lLXFMm18tV8rOOXK0=; 4:5fjASeJKxTO1qQ1WAisfvq0Cxjs+Nq2ZnYVDbD0eRFBoDhZ/h8IgLSWXdNP490llQQinNmvHDLlw+vAE3FK0Y+GSl0F2VnAPHQy5S9/ZCYlgg3A4RnVQF1nhE3o36AyDxxvF8IQgzl2Yq0oCklHCohcNZyDjvZTbROZZGwU4fD24kurGTEF4Vxo5oXbNv/7n1y0o5yYZLH8IeYJ7yX4BtInNcOjhn/ZMItfQXEKKwyWV1FP7DQWJne5QJ1gi6blCwGbuD+ajlpWe15UsAJfR7BUnesldgHgHc39de5xKuRI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0787; X-Microsoft-Antispam-PRVS: <AM2PR02MB0787294C4765222095BADE60BFA10@AM2PR02MB0787.eurprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:AM2PR02MB0787; BCL:0; PCL:0; RULEID:; SRVR:AM2PR02MB0787; X-Forefront-PRVS: 06157D541C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(52044002)(24454002)(377424004)(51704005)(46406003)(47776003)(77156002)(23726002)(50986999)(66066001)(76176999)(110136002)(77096005)(33646002)(62966003)(5001960100002)(92566002)(189998001)(2950100001)(50466002)(42186005)(122386002)(86362001)(19580405001)(19580395003)(50226001)(46102003)(87976001)(40100003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR02MB0787; H:cchemparathy-ubuntu; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM2PR02MB0787; 23:U0kUdeg6SpPK1fj39eqeM7dTBuwU6Gvvla2svqglDXOI/9XGx5mqKIzRu8GnfYXdDP0Fu6d9QFX2QcVC1WzDo69oGYbWa5tu1jntbCpYzfFappXgkLXKGrYZr32IC7b7sYOOV0EH5SrDMwK3CR3gctqwcv8dzeOU3NSVlEcqIuEb0L+FFyUIP29gKhNUoKqSRp/FyYxLJUsjCMi8QrVdRtu0vqBPpfIvyWQ+zlSWd6lXcsnwPcF+Jjt0SEjTp4WF3lOq33Ammwhu+CUvUNMM+C55p6yTjuUlMfKuMkpgUdmdD7QcQQ5sNrAamwlRUTWGfA/VO5GL/TyIhzqrBg9+JD/XkkpnO5KecWMZzMOJb9TRvKaKiRX/o/LvxG/fUL0OnH92XKuiVnRKBmNz202UBfUauiafxuOB8TwFNBMgFtXq01W7h2i06Q3PA3BIru+lFek2t2pBd5pTLtcAqJNHKSEJn+0o8f2sLBVXd3PY2VE/90LzzCBPjmE3CPg9naINxKIP14hyHCzc2w1C5+Bm+bxrJ6QIdY6ZOMVQT9W0/o06uQZVwMlGZqWIiJdX4nkKqgsfH5hVnxvFZo1RhhdpYilnYHdTMAeHbtwtrLjqFQCXeXhK7JBR4G+X6WZI0Uq7yAlqYvLm9nSCV1f2otZL61PhLob/1LA1csYqkNcFS4XmmCTAUDdYHo/dXnXaxFcm4Wv06znnqq4KOXtfrBBLfW9SN4g2UosdmvXYqr/JZZqXsL788TrSD0oDeDfX6+YhfwkRJhnZE+AdDHaE++QFANRB1kq500I2222r3FVMr9yopmsZnDHuivKuOffhFs2L/ouGIlZoR5BJ14UEDYiyWw== X-Microsoft-Exchange-Diagnostics: 1; AM2PR02MB0787; 5:NB4LbQ8TttIFByT2NUE+AS+SzivdODYiodGPVXyreQl9D37baZPQVu9EGATHSVSnTLYsJ7XLu5rpldnzbbIoCsmIJetCASdggOcYmHrdc4iq562nI3V3nddXtjtcTqE7Wd/gm3AkVpuBeYfiFWKadg==; 24:n59Izqjcig7a0OPSkn/zOR4J5+O++P7iKfUD8SoSDtkhNXorBbzp866IwWnichI1P9lDA5VMusOVc6A+3CDL5zpuiMRcfMtDy7lE2KxDSzE=; 20:jBm/nTKlEtHEomCdvStGO5dLZZFJriBVU3FGjkmL8sfxU1SkQSShR+5f3mPVjOkpSM9Mf7VBPWjjNeouvIXBUw== X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2015 20:35:02.7194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR02MB0787 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Jun 2015 20:35:04 -0000 On Mon, 22 Jun 2015 22:16:59 +0200 Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > 2015-06-05 15:31, Dumitrescu, Cristian: > > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > > meta-data fields. > > > Forcing aligned accesses is not really required, so this is > > > removing an unneeded constraint. > > > This issue was met during testing of the new version of the > > > ip_pipeline application. There is no performance impact. > > > This change has no ABI impact, as the previous code that uses > > > aligned accesses continues to run without any issues. > > > > > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> > > > > Ack-ed by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > Applied, thanks > > Cyril, feel free to fix it if it breaks with Tile arch. Also, in the code, doesn't the following break when mbuf_priv_size != 0? > #define RTE_MBUF_METADATA_UINT8_PTR(mbuf, offset) \ > (&((uint8_t *) &(mbuf)[1])[offset]) Thanks -- Cyril.