From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com
 [209.85.223.174]) by dpdk.org (Postfix) with ESMTP id F13BEC660
 for <dev@dpdk.org>; Thu, 25 Jun 2015 15:45:49 +0200 (CEST)
Received: by iebrt9 with SMTP id rt9so54666209ieb.2
 for <dev@dpdk.org>; Thu, 25 Jun 2015 06:45:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=Twe4h6Rg+AeCZ2+a0eOrSIerp78XFRjcND+JpwduEnA=;
 b=BwVBo4OOmOUT2wPTcc0FdDrSXwlQxayOUcnJMxxUsd13Owyn0SP8PA5A/0Ep0OE1xH
 73XAr6BoBfMVZCXy0oTF09q3xmDcKJbP4njvFUih1+OWdQNfTyH5IyyuyhMwPfVui6pQ
 lsxCjyFmlUbWDunBVHMLR7nHUld7jJvG0/QA2DzBoQ7JKwF4HvqBT+RYbppZpJHDRfwS
 XSvdhMcc+mUtqGHOixd5cCqBJwKvDIE6ipv9A/2Vp+Fv2YVzBTOa6PVeqYBDygtki9Sv
 B/BLX1DqF7zSi7kfGmWUFkQJpOJB1k/8IKlGWbc7lkFbw6MaJWR2xv8ZPuVGBXJpDqfr
 sNiQ==
X-Gm-Message-State: ALoCoQlTSw82RZK54Jd4btl8VAxR/E8O4CiJ6xV8e24L37Rkal9yvymFhBgiKyRLYE6iVkGMK6gn
X-Received: by 10.43.66.5 with SMTP id xo5mr42932376icb.57.1435239949487;
 Thu, 25 Jun 2015 06:45:49 -0700 (PDT)
Received: from uryu.home.lan ([144.160.5.83])
 by mx.google.com with ESMTPSA id t7sm3351079ign.8.2015.06.25.06.45.48
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 25 Jun 2015 06:45:49 -0700 (PDT)
Date: Thu, 25 Jun 2015 09:45:46 -0400
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150625094546.77e95f26@uryu.home.lan>
In-Reply-To: <1434579735-15496-3-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1434579735-15496-1-git-send-email-liang-min.wang@intel.com>
 <1434579735-15496-3-git-send-email-liang-min.wang@intel.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 2/4] ixgbe: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 13:45:50 -0000

On Wed, 17 Jun 2015 18:22:13 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +
> +static reg_info ixgbe_regs_general[] = {
> +	{IXGBE_CTRL, 1, 1, "IXGBE_CTRL"},
> +	{IXGBE_STATUS, 1, 1, "IXGBE_STATUS"},
> +	{IXGBE_CTRL_EXT, 1, 1, "IXGBE_CTRL_EXT"},
> +	{IXGBE_ESDP, 1, 1, "IXGBE_ESDP"},
> +	{IXGBE_EODSDP, 1, 1, "IXGBE_EODSDP"},
> +	{IXGBE_LEDCTL, 1, 1, "IXGBE_LEDCTL"},
> +	{IXGBE_FRTIMER, 1, 1, "IXGBE_FRTIMER"},
> +	{IXGBE_TCPTIMER, 1, 1, "IXGBE_TCPTIMER"},
> +	{0, 0, 0, ""}
> +};
> +
> +static reg_info ixgbevf_regs_general[] = {
> +	{IXGBE_CTRL, 1, 1, "IXGBE_CTRL"},
> +	{IXGBE_STATUS, 1, 1, "IXGBE_STATUS"},
> +	{IXGBE_VFLINKS, 1, 1, "IXGBE_VFLINKS"},
> +	{IXGBE_FRTIMER, 1, 1, "IXGBE_FRTIMER"},
> +	{IXGBE_VFMAILBOX, 1, 1, "IXGBE_VFMAILBOX"},
> +	{IXGBE_VFMBMEM, 16, 4, "IXGBE_VFMBMEM"},
> +	{IXGBE_VFRXMEMWRAP, 1, 1, "IXGBE_VFRXMEMWRAP"},
> +	{0, 0, 0, ""}
> +};
> +

All these tables should be const
and API may need to change.