From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com
 [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id A6908CA18
 for <dev@dpdk.org>; Sat, 27 Jun 2015 03:32:43 +0200 (CEST)
Received: by pdbci14 with SMTP id ci14so83972330pdb.2
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:32:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=xtiW7bqSoxQfvM4Ye0otbwrHdkReyK/nCki9w7yWf+w=;
 b=d8xziVTZPioFm4WJ1uEapARGR6Gz79VIo8jap4ThOlQ3zLAarkar/jfMTGXGUxOlh9
 xtKOqsGZsMpXpkoqRH+PxJpNuDyRH1w48MNhVRn08YTROqUp2qHbCaahxfbvDnwrxM5L
 z8ELiZO8tlKdCxL0m1aJhNzh7K9WfaJFJKuh0TDYGSaszPilmXUx46uSJqEu4G00/qIM
 a+xHAaO22XiJYOsV5ASzuWuXNyVw1/WZaE1iT3vMu/3E+aZFuA+0z7VWDfYbaYSjGPg5
 hTjNcVhtnL6KNF82ztPXOWp3x5XgJlOZomqFYy/SZpVAv+dEjZyPjFetOBFe+Vr4d/jY
 qcRA==
X-Gm-Message-State: ALoCoQnEGF8yg1Q/TMJJW1W6acbj3QeNnxWtHUX9VVbImHUvqDPOkCrwl/+Yapud0Bo4JOwujadF
X-Received: by 10.70.32.164 with SMTP id k4mr8824176pdi.138.1435368762906;
 Fri, 26 Jun 2015 18:32:42 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id nq2sm34657295pdb.70.2015.06.26.18.32.42
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 Jun 2015 18:32:42 -0700 (PDT)
Date: Fri, 26 Jun 2015 18:32:48 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150626183248.44a55e34@urahara>
In-Reply-To: <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2015 01:32:43 -0000

On Fri, 26 Jun 2015 21:19:05 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +static int
> +ixgbe_get_reg_length(struct rte_eth_dev *dev __rte_unused)
> +{
> +	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private)

The dev arg is used, and therefore should not be marked __rte_unused.