From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id D0A23CA5E
 for <dev@dpdk.org>; Sat, 27 Jun 2015 03:33:57 +0200 (CEST)
Received: by paceq1 with SMTP id eq1so76381615pac.3
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:33:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=6c0tJkOXvJpru6rTi/hUYx11qBmK13iUdhTvm5VCguQ=;
 b=LHGt8YDDukFybKlWUTfeRx4i/Uc03Rq2Obog9ZIJGP3SgoGMkYVhhIcVrK0I8eXPRG
 eaXRXQ6ltLdY0kgvOOVvF+2A1Gm+tD5Bs3Inrt889e8PtqY8soXbhrm75eX18mqxOq/D
 QGg0eOcYUyGikaM84jK3G3+D4K1Onby9WWNM5XdBpe3I1FRhT88g2ZXHTMD3HDUNqMFI
 B5KQkf5pHEKtjq+zX/gS6hqud4b/fkUnp+5u3scKacXF3DZZQ/aJCEmXONkm9qnU8LDa
 T3z+fvzIYv85rH/DEzKW39LDBEb0yHYqRcplHQANwTQyNwBXQP/k87PVlNDWQ4SMw4uT
 4cHw==
X-Gm-Message-State: ALoCoQnym7YtBaEnAYXakR1J8+1WE/7eT9e438sy9oJ+6lDw0dO8sPrIHi72hbKN6kuIzhRdknH1
X-Received: by 10.70.102.132 with SMTP id fo4mr8760042pdb.31.1435368837199;
 Fri, 26 Jun 2015 18:33:57 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id qo6sm34782133pab.23.2015.06.26.18.33.56
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 Jun 2015 18:33:56 -0700 (PDT)
Date: Fri, 26 Jun 2015 18:34:03 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150626183403.6a3dc4fb@urahara>
In-Reply-To: <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2015 01:33:58 -0000

On Fri, 26 Jun 2015 21:19:05 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +	reg_group = reg_set[g_ind++];
> +	while (reg_group) {
> +		count += ixgbe_regs_group_count(reg_group);
> +		reg_group = reg_set[g_ind++];
> +	}

I don't care what checkpatch says, this an example of a loop
which reads better as:

        while ((reg_group = reg_set[g_ind++]))
               count += ixgbe_regs_group_count(reg_group);