From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 37D1BCA62
 for <dev@dpdk.org>; Sat, 27 Jun 2015 03:34:47 +0200 (CEST)
Received: by pactm7 with SMTP id tm7so76368161pac.2
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:34:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=yEhpbCBjIq0LOCb/acSjNdGvx9hg7DziClnre28176c=;
 b=ftI9JLpAW/qO+18YVUxQphJqGKTgyiYLFS1R8vStvy1czVKtIoEx/dibjqnKQBaSpC
 djpxQj8bng/R7PSFI4rBPk3knWGrY1qCtzicEcpIbwRoJE/GmKpXN5f8bjY9rBH8tlsc
 Mjm/Tpjlt1/wID5n7qIuSlQsSY6LLW+5CWHXeEpSIZByqRZQGrrmvBxF2iUr5hN1nfgB
 /dXrR9CgI4BVw7Dllb2WUniyv/J5RzM+GLYyFDMIDpYmjcbupt4uzpO0zfY2/U5tUTbL
 eZcEkj7f1OLE+XwfY6NFiEtrHij1+XQgEHG0M8vzbvRFbyNwabu8+DLqwNTzgZtWd0Ey
 elyQ==
X-Gm-Message-State: ALoCoQmnwm18R3XYBtUmkqyq973OaKEMOgYjwe2qcpT2tifaZi4rhAwO2nJyVKkH63+6ksJe5a02
X-Received: by 10.68.169.34 with SMTP id ab2mr8612373pbc.120.1435368886660;
 Fri, 26 Jun 2015 18:34:46 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id tr2sm11168031pab.33.2015.06.26.18.34.46
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 Jun 2015 18:34:46 -0700 (PDT)
Date: Fri, 26 Jun 2015 18:34:52 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150626183452.3c5e9e3b@urahara>
In-Reply-To: <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2015 01:34:47 -0000

On Fri, 26 Jun 2015 21:19:05 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +static struct reg_info ixgbe_regs_general[] = {
> +	{IXGBE_CTRL, 1, 1, "IXGBE_CTRL"},
> +	{IXGBE_STATUS, 1, 1, "IXGBE_STATUS"},
> +	{IXGBE_CTRL_EXT, 1, 1, "IXGBE_CTRL_EXT"},
> +	{IXGBE_ESDP, 1, 1, "IXGBE_ESDP"},
> +	{IXGBE_EODSDP, 1, 1, "IXGBE_EODSDP"},
> +	{IXGBE_LEDCTL, 1, 1, "IXGBE_LEDCTL"},
> +	{IXGBE_FRTIMER, 1, 1, "IXGBE_FRTIMER"},
> +	{IXGBE_TCPTIMER, 1, 1, "IXGBE_TCPTIMER"},
> +	{0, 0, 0, ""}
> +};
> +

All these fixed data structures should be marked as const.
You may have to fixup some other code that is assuming otherwise.