From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 36192CA6E
 for <dev@dpdk.org>; Sat, 27 Jun 2015 03:35:49 +0200 (CEST)
Received: by padev16 with SMTP id ev16so76619557pad.0
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:35:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=1d4Ea7IOfuS5mmocCiwjidGr1BAJFXLbLjkYCP7uTb8=;
 b=HE5la7lgxOv2ptS4ZeaWplmFxr3pjVHzJz3fqg6hXjlKT+W4DlHTq0C4s9cNGxEQn9
 SquzZ8OriON3wAD2WsVUQCmYwbQO95JzpvOteXG2AjA5me+NlbqCmV6vVLbqgQ8mlgdA
 kXu3l0DS7YoUm3P1LPXZaWNXaU78RHL+swEgYA1vsxb0nvkQbuvj39knKpXvduB0S201
 EBDB3k8hfg7bW4tjW3JXW/6sBNcEeGID0G+6SBQwWK7y8NqAOkslmtL3PlcqjECY8Fex
 97pt+QiTufLsfPHkaao04isdCbn9HlbfHmzSfN3wvaMXsfDaasSTSA99gQyDyAz2Ki44
 SLjA==
X-Gm-Message-State: ALoCoQmofqCFSvg8ZInZL0wn/rBwJIo/YZHqXiO/pIhJ841e1c+OVGxiCpwqhcwOetMnz59RV1xx
X-Received: by 10.67.30.102 with SMTP id kd6mr8719924pad.132.1435368948657;
 Fri, 26 Jun 2015 18:35:48 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ql9sm34566633pbc.65.2015.06.26.18.35.48
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 Jun 2015 18:35:48 -0700 (PDT)
Date: Fri, 26 Jun 2015 18:35:54 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150626183554.468aa9ee@urahara>
In-Reply-To: <1435367948-20240-4-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-4-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 3/5] igb: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2015 01:35:49 -0000

On Fri, 26 Jun 2015 21:19:06 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +static struct reg_info igb_regs_general[] = {
> +	{E1000_CTRL, 1, 1, "E1000_CTRL"},
> +	{E1000_STATUS, 1, 1, "E1000_STATUS"},
> +	{E1000_CTRL_EXT, 1, 1, "E1000_CTRL_EXT"},
> +	{E1000_MDIC, 1, 1, "E1000_MDIC"},
> +	{E1000_SCTL, 1, 1, "E1000_SCTL"},
> +	{E1000_CONNSW, 1, 1, "E1000_CONNSW"},
> +	{E1000_VET, 1, 1, "E1000_VET"},
> +	{E1000_LEDCTL, 1, 1, "E1000_LEDCTL"},
> +	{E1000_PBA, 1, 1, "E1000_PBA"},
> +	{E1000_PBS, 1, 1, "E1000_PBS"},
> +	{E1000_FRTIMER, 1, 1, "E1000_FRTIMER"},
> +	{E1000_TCPTIMER, 1, 1, "E1000_TCPTIMER"},
> +	{0, 0, 0, ""}
> +};
> +

All pre-set reg_info should be const.

And this as well:

> +static struct reg_info *igb_regs[] = {
> +				igb_regs_general,
> +				igb_regs_nvm,
> +				igb_regs_interrupt,
> +				igb_regs_fctl,
> +				igb_regs_rxdma,
> +				igb_regs_rx,
> +				igb_regs_tx,
> +				igb_regs_wakeup,
> +				igb_regs_mac,
> +				NULL};
> +