From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 4EC7D683D
 for <dev@dpdk.org>; Mon, 29 Jun 2015 17:30:40 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 29 Jun 2015 08:30:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,699,1427785200"; d="scan'208";a="752575624"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.162])
 by fmsmga002.fm.intel.com with SMTP; 29 Jun 2015 08:30:37 -0700
Received: by  (sSMTP sendmail emulation); Mon, 29 Jun 2015 16:30:36 +0025
Date: Mon, 29 Jun 2015 16:30:36 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <20150629153036.GB3260@bricha3-MOBL3>
References: <1432016513-8456-5-git-send-email-mukawa@igel.co.jp>
 <1435546610-4533-1-git-send-email-mukawa@igel.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435546610-4533-1-git-send-email-mukawa@igel.co.jp>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/8] Add Port Hotplug support to BSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2015 15:30:40 -0000

On Mon, Jun 29, 2015 at 11:56:42AM +0900, Tetsuya Mukawa wrote:
> This patch series adds port hotplug support to BSD.
> Before applying, following patches should be applied.
>  - [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c
>  - [PATCH v6 2/5] eal: Close file descriptor of uio configuration
>  - [PATCH v6 3/5] eal: Fix memory leaks and needless increment of pci_map_addr
>  - [PATCH v6 4/5] eal/bsdapp: Change names of pci related data structure
>  - [PATCH v6 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp
> 
> Some functions will be consolidated after applying the patches, because
> these functions are implemented in both Linux and BSD code.
> 
> PATCH v2 changes:
>  - Fix license of eal_common_pci_uio.c
> 
> PATCH v1 changes:
>  - Rebase to below latest patch series.
>    - [PATCH v6] Clean up pci uio implementations
> 
>
The majority of patches in this set seem to be more concerned with cleaning up
common code between linux and FreeBSD rather than adding hotplug support. Are those
changes better made as part of the previous patchset listed as a requirement of
this?

/Bruce