From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E7D045927 for ; Tue, 30 Jun 2015 14:50:51 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 30 Jun 2015 05:50:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,377,1432623600"; d="scan'208";a="737664615" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.162]) by fmsmga001.fm.intel.com with SMTP; 30 Jun 2015 05:50:49 -0700 Received: by (sSMTP sendmail emulation); Tue, 30 Jun 2015 13:50:48 +0025 Date: Tue, 30 Jun 2015 13:50:48 +0100 From: Bruce Richardson To: Tetsuya Mukawa Message-ID: <20150630125048.GB3664@bricha3-MOBL3> References: <1432016513-8456-5-git-send-email-mukawa@igel.co.jp> <1435546610-4533-1-git-send-email-mukawa@igel.co.jp> <1435546610-4533-5-git-send-email-mukawa@igel.co.jp> <20150629152837.GA3260@bricha3-MOBL3> <55924E89.6010705@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55924E89.6010705@igel.co.jp> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 4/8] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 12:50:52 -0000 On Tue, Jun 30, 2015 at 05:08:41PM +0900, Tetsuya Mukawa wrote: > On 2015/06/30 0:28, Bruce Richardson wrote: > > On Mon, Jun 29, 2015 at 11:56:46AM +0900, Tetsuya Mukawa wrote: > >> From: "Tetsuya.Mukawa" > >> > >> This patch consolidates below functions, and implements these in common > >> eal code. > >> - rte_eal_pci_probe_one_driver() > >> - rte_eal_pci_close_one_driver() > >> > >> Because pci_map_device() is only implemented in linuxapp, the patch > >> implements it in bsdapp too. This implemented function will be merged to > >> linuxapp one with later patch. > >> > >> Signed-off-by: Tetsuya Mukawa > >> --- > >> lib/librte_eal/bsdapp/eal/eal_pci.c | 74 ++--------------- > >> lib/librte_eal/common/eal_common_pci.c | 129 ++++++++++++++++++++++++++++ > >> lib/librte_eal/common/eal_private.h | 21 ++--- > >> lib/librte_eal/linuxapp/eal/eal_pci.c | 148 ++------------------------------- > >> 4 files changed, 153 insertions(+), 219 deletions(-) > >> > >> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c > >> index c7017eb..2a623e3 100644 > >> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > >> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > >> @@ -88,7 +88,7 @@ static struct rte_tailq_elem rte_uio_tailq = { > >> EAL_REGISTER_TAILQ(rte_uio_tailq) > >> > >> /* unbind kernel driver for this device */ > >> -static int > >> +int > >> pci_unbind_kernel_driver(struct rte_pci_device *dev __rte_unused) > >> { > >> RTE_LOG(ERR, EAL, "RTE_PCI_DRV_FORCE_UNBIND flag is not implemented " > >> @@ -430,6 +430,13 @@ skipdev: > >> return 0; > >> } > >> > >> +/* Map pci device */ > >> +int > >> +pci_map_device(struct rte_pci_device *dev) > >> +{ > >> + return pci_uio_map_resource(dev); > >> +} > >> + > > These lines are added here, but removed again in the next patch in the series. > > Though not wrong, per-se, it just seems untidy. Perhaps the patchset order needs > > to be changed somewhat? > > > > /Bruce > > Hi Bruce, > > I appreciate your comment. > Sure, I will change the order of these patches. > Could you please check patches I will send later? > Yes, I'll test them on FreeBSD shortly. /Bruce