From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 32EF62A58
 for <dev@dpdk.org>; Sat,  4 Jul 2015 01:03:06 +0200 (CEST)
Received: by pdcu2 with SMTP id u2so70996444pdc.3
 for <dev@dpdk.org>; Fri, 03 Jul 2015 16:03:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=yozw1cxetOZX2z0OmT/o/9OP0VN/TQUTE5rubSP1QaI=;
 b=cWfrabfOWATVLGqu4Qsz0VM9KZGwTC643o4Q9HkZdljEazqCpmbUThdRVLu//QMdC/
 m4FWkF6JLF23aDFxyaBR3idKcY7JdpN3cxBauRSQSANJK/hgtv0xSuIur8Q6pR88ZeC3
 pl7pS92WDEIvEH5bBvvxtJguEr6FKOS6+mokI3TwehX3O9NvBHd4o/JUzyRHYzW+CRTd
 32dXgX5e+k9Wk0GHbAyiA4pEM5ZJOmMIQctFwPjiotuhgm4WQFsIiVTrkPIWrulKAXdn
 I5tMYR4FSIXRhJ3Voz91i1tt9QLAWtZetf9ASlY+zVVh8HdigfHvjlVh/Y3hrFfWklNc
 q2SQ==
X-Gm-Message-State: ALoCoQkVmIqMF68Hj9gU9oHKnyHtJUNvJiB9ufl4v23SOYRvw8V/tRFnO17eZxlVzdM0eIqReAb7
X-Received: by 10.68.91.5 with SMTP id ca5mr44013447pbb.105.1435964585566;
 Fri, 03 Jul 2015 16:03:05 -0700 (PDT)
Received: from uryu.home.lan (cpe-72-130-168-110.hawaii.res.rr.com.
 [72.130.168.110])
 by mx.google.com with ESMTPSA id g2sm10183151pdh.11.2015.07.03.16.03.04
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 03 Jul 2015 16:03:05 -0700 (PDT)
Date: Fri, 3 Jul 2015 13:03:00 -1000
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20150703130300.4d0f2828@uryu.home.lan>
In-Reply-To: <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com>
 <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to
 setup/teardown fns
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2015 23:03:06 -0000

On Fri,  3 Jul 2015 16:40:05 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -1757,7 +1757,7 @@ ixgbe_recv_pkts_lro_bulk_alloc(void *rx_queue, struct rte_mbuf **rx_pkts,
>   * needed. If the memzone is already created, then this function returns a ptr
>   * to the old one.
>   */
> -static const struct rte_memzone *
> +static const struct rte_memzone * __attribute__((cold))
>  ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
>  		      uint16_t queue_id, uint32_t ring_size, int socket_id)
>  {

This function is used in multiple drivers and should really be in common code.