From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 817B75A68
 for <dev@dpdk.org>; Wed,  8 Jul 2015 13:04:27 +0200 (CEST)
Received: from voip-107-15-76-160.kyn.rr.com ([107.15.76.160] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1ZCn9M-0001FC-86; Wed, 08 Jul 2015 07:04:25 -0400
Date: Wed, 8 Jul 2015 07:04:23 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150708110423.GA24635@hmsreliant.think-freely.org>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <1435586380-1673-1-git-send-email-nhorman@tuxdriver.com>
 <7897190.qLvkiMcu3A@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7897190.qLvkiMcu3A@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv4 1/4] rte_compat.h : Clean up some typos
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 11:04:27 -0000

On Wed, Jul 08, 2015 at 11:52:51AM +0200, Thomas Monjalon wrote:
> Hi Neil,
> 
> 2015-06-29 09:59, Neil Horman:
> > - *	int __vsym foo_v20(char *string)
> > + *	int foo_v20(char *string)
> [...]
> > -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", "RTE_STR(b)"@@DPDK_"RTE_STR(n))
> > +#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", " RTE_STR(b) "@@DPDK_" RTE_STR(n))
> >  #define __vsym __attribute__((used))
> 
> In this patch, you removed __vsym from the example but the #define still exists.
> Should it be removed? or documented?
> 
> Thanks
> 

The latter, I'll try send a follow on patch today
Neil