From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id C8ADC5A51 for ; Fri, 17 Jul 2015 02:53:44 +0200 (CEST) Received: by padck2 with SMTP id ck2so51068272pad.0 for ; Thu, 16 Jul 2015 17:53:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Y3NN7F2sRZdS2XN3SBD4KaJIL0s5zxD/5YFkW+GaoU4=; b=Q+xaeidaTvMkq34XFWhmtsr3PKXA1lkq3bp5GacYxg+/r9jDdopi4F+Q4XSSWNS3ZQ QJlAOVlj+K1uRzAIOzr56GSxPWIHggDQXbC2oxhQEVZsOExwJQZvUbb8kKZ1yWslcNz8 vLL2hTfdRhSCQYMxBpMN5E1dLMuMC10RpzieqxA9VbYEsZ+v8QBmJGSvMYKj4DlqGXWg Jh6tMYxLp1k2QUC9sEcMZb8Sqe/uNDW3SmSO49q0Om8oXLUJaEPfq9zzZvgPQclgIAXk Zl9ZcTKcmn5mmPnBCykcN1E6e+Sgynbfhp/BkfVkTVYHnS5V3BDWKFRAmSe0YaVZDMc1 FaqA== X-Gm-Message-State: ALoCoQmqve70985oUH3YkADaiBtgM/OL/FCFyeKQ8gURucDe74afY5Rb+CsrnlI5nPC04Me3AfYt X-Received: by 10.68.204.133 with SMTP id ky5mr23884609pbc.67.1437094424228; Thu, 16 Jul 2015 17:53:44 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ti10sm9231055pab.20.2015.07.16.17.53.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 17:53:43 -0700 (PDT) Date: Thu, 16 Jul 2015 17:53:52 -0700 From: Stephen Hemminger To: Bernard Iremonger Message-ID: <20150716175352.4acce1bc@urahara> In-Reply-To: <1436968265-14362-1-git-send-email-bernard.iremonger@intel.com> References: <1436968265-14362-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/6] virtio PCI Port Hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 00:53:45 -0000 On Wed, 15 Jul 2015 14:50:59 +0100 Bernard Iremonger wrote: > Changes in V6: > Rebase. > Use queue_release function in dev_uninit function (patch 5) > Set vq to NULL in queue release function. > Move previous patch 5 to patch 6. > > > Changes in V5: > Rebase. > Add proper queue release patch (patch 3). > Reorder patches, moved previous patch 3 to patch 4, > moved previous patch 4 to patch 5. > > Changes in V4: > Rebase to latest code. > Move freeing of queue memory from uninit() function to close() function. > Change to testpmd to facilate testing on VM. > > Changes in V3: > Rebase to latest code. > Free queue memory in uninit() function. > > Changes in V2: > Rebase to use new drivers directory. > > Bernard Iremonger (6): > virtio: add support for PCI Port Hotplug > virtio: check vq parameter in virtqueue_detatch_unused() function > virtio: add proper queue release > virtio: free queue memory in virtio_dev_close() > virtio: use queue_release in dev_uninit > test-pmd: remove call to rte_eth_promiscuous_disable() from > detach_port() > > app/test-pmd/testpmd.c | 4 +- > drivers/net/virtio/virtio_ethdev.c | 120 +++++++++++++++++++++++++++++-------- > drivers/net/virtio/virtio_ethdev.h | 8 ++- > drivers/net/virtio/virtio_rxtx.c | 12 ++++ > drivers/net/virtio/virtqueue.c | 14 +++-- > 5 files changed, 123 insertions(+), 35 deletions(-) > Looks good thanks. Acked-by: Stephen Hemminger