From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 3136D902
 for <dev@dpdk.org>; Fri, 17 Jul 2015 14:25:57 +0200 (CEST)
Received: from voip-107-15-76-160.kyn.rr.com ([107.15.76.160] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1ZG4i6-0002ZM-QE; Fri, 17 Jul 2015 08:25:52 -0400
Date: Fri, 17 Jul 2015 08:25:48 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Message-ID: <20150717122548.GA3931@neilslaptop.think-freely.org>
References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com>
 <20150713104218.GB9631@hmsreliant.think-freely.org>
 <B27915DBBA3421428155699D51E4CFE2F6B3FA@IRSMSX103.ger.corp.intel.com>
 <20150713135955.GC9631@hmsreliant.think-freely.org>
 <B27915DBBA3421428155699D51E4CFE2F6F572@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F6F572@IRSMSX103.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2015 12:25:57 -0000

On Fri, Jul 17, 2015 at 11:45:10AM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Monday, July 13, 2015 3:00 PM
> > To: Mcnamara, John
> > Cc: dev@dpdk.org; vladz@cloudius-systems.com
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> > 
> > > > > -		dev_started : 1;   /**< Device state: STARTED(1) / STOPPED(0). */
> > > > > +		dev_started : 1,   /**< Device state: STARTED(1) / STOPPED(0). */
> > > > > +		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> > > > >
> > > > >
> > >
> > Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil
> 
> Hi,
> 
> Just pinging Chao Zhu on this again so that it isn't forgotten.
> 
> Neil, just to be clear, are you looking for a validate-abi.sh check on PPC?
> 
Yes, correct.
> Just for context, the lro flag doesn't seem to be used anywhere that would be affected by endianness:
> 
>     $ ag -w "\->lro"             
>     drivers/net/ixgbe/ixgbe_rxtx.c
>     3767:   if (dev->data->lro) {
>     3967:   dev->data->lro = 1;
> 
>     drivers/net/ixgbe/ixgbe_ethdev.c
>     1689:   dev->data->lro = 0;
> 
But this data is visible to the outside application, correct?  If so then we
can't rely on internal-only usage as a guide.  If it is only internally visible,
then yes, you are correct, endianess is not an issue then
neil

> John.
> -- 
> 
>