From: Bruce Richardson <bruce.richardson@intel.com>
To: Zoltan Kiss <zoltan.kiss@linaro.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] ixgbe_recv_scattered_pkts_vec split_flags question
Date: Tue, 21 Jul 2015 16:17:14 +0100 [thread overview]
Message-ID: <20150721151714.GA5712@bricha3-MOBL3> (raw)
In-Reply-To: <55AE60C7.8050406@linaro.org>
On Tue, Jul 21, 2015 at 04:09:59PM +0100, Zoltan Kiss wrote:
> Hi,
>
> I have a question regarding split_flags in this question. It's defined as an
> array of 1 byte unsigned ints:
>
> uint8_t split_flags[RTE_IXGBE_VPMD_RX_BURST] = {0};
>
> RTE_IXGBE_VPMD_RX_BURST is 32, so it will be 32 bytes. Then we cast it into
> a pointer for 4 byte values, and check the first 4 elements of that array
>
> const uint32_t *split_fl32 = (uint32_t *)split_flags;
> if (rxq->pkt_first_seg == NULL &&
> split_fl32[0] == 0 && split_fl32[1] == 0 &&
> split_fl32[2] == 0 && split_fl32[3] == 0)
>
> So we only check the first half of this 32 byte array. But
> _recv_raw_pkts_vec() seems to use the whole array. Is this a bug or a
> feature? Or am I mistaken in the math somewhere?
>
> Regards,
>
> Zoltan Kiss
Yes, you are right, this does look like a bug. The uint32_t's should probably be
uint64_t's. :-(
/Bruce
prev parent reply other threads:[~2015-07-21 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 15:09 Zoltan Kiss
2015-07-21 15:17 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721151714.GA5712@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=zoltan.kiss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).