From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30481C322 for ; Wed, 22 Jul 2015 10:29:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Jul 2015 01:29:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,522,1432623600"; d="scan'208";a="733273975" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by orsmga001.jf.intel.com with SMTP; 22 Jul 2015 01:29:14 -0700 Received: by (sSMTP sendmail emulation); Wed, 22 Jul 2015 09:29:13 +0025 Date: Wed, 22 Jul 2015 09:29:13 +0100 From: Bruce Richardson To: "Lu, Wenzhuo" Message-ID: <20150722082912.GA11652@bricha3-MOBL3> References: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909CFBCA0@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFBCA0@shsmsx102.ccr.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix check for split packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 08:29:17 -0000 On Wed, Jul 22, 2015 at 01:44:14AM +0100, Lu, Wenzhuo wrote: > Hi Bruce, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, July 21, 2015 11:25 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] ixgbe: fix check for split packets > > > > The check for split packets to be reassembled in the vector ixgbe PMD was > > incorrectly only checking the first 16 elements of the array instead of all 32. This > > is fixed by changing the uint32_t values to be uint64_t instead. > > > > Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx") > > > > Reported-by: Zoltan Kiss > > Signed-off-by: Bruce Richardson > > --- > > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > index 9f24849..cdad3e0 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > @@ -549,7 +549,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct > > rte_mbuf **rx_pkts, > > return 0; > > > > /* happy day case, full burst + no packets to be joined */ > > - const uint32_t *split_fl32 = (uint32_t *)split_flags; > > + const uint64_t *split_fl32 = (uint64_t *)split_flags; > Why not change the name to split_fl64? I don't think it's appropriate to keep it be split_fl32. > Thanks. > Quite right, that's the obvious change! I'll do a V2. /Bruce