* [dpdk-dev] [PATCH] config: disable bnx2x driver
@ 2015-07-28 17:16 Thomas Monjalon
2015-07-28 18:29 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-07-28 17:16 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
This driver has too many issues:
- too big
- bad coding style
- no git history (dropped in 2 patches)
- no documentation
- no BSD support
- no maintainer
And the biggest one, constraining this disabling:
- many build issues
If the last 4 issues are not fixed in the next release 2.2,
the driver must be removed.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
config/common_linuxapp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 72373b6..bda9a63 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -214,7 +214,7 @@ CONFIG_RTE_LIBRTE_MLX4_SOFT_COUNTERS=1
#
# Compile burst-oriented Broadcom PMD driver
#
-CONFIG_RTE_LIBRTE_BNX2X_PMD=y
+CONFIG_RTE_LIBRTE_BNX2X_PMD=n
CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n
CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=n
--
2.4.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] config: disable bnx2x driver
2015-07-28 17:16 [dpdk-dev] [PATCH] config: disable bnx2x driver Thomas Monjalon
@ 2015-07-28 18:29 ` Stephen Hemminger
2015-07-28 21:17 ` Thomas Monjalon
2015-07-28 21:38 ` Stephen Hemminger
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2015-07-28 18:29 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> This driver has too many issues:
> - too big
> - bad coding style
> - no git history (dropped in 2 patches)
> - no documentation
> - no BSD support
The main issue with BSD is loading the firmware.
Probably just need to change the path.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] config: disable bnx2x driver
2015-07-28 17:16 [dpdk-dev] [PATCH] config: disable bnx2x driver Thomas Monjalon
2015-07-28 18:29 ` Stephen Hemminger
@ 2015-07-28 21:17 ` Thomas Monjalon
2015-07-28 21:38 ` Stephen Hemminger
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-07-28 21:17 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2015-07-28 19:16, Thomas Monjalon:
> This driver has too many issues:
> - too big
> - bad coding style
> - no git history (dropped in 2 patches)
> - no documentation
> - no BSD support
> - no maintainer
> And the biggest one, constraining this disabling:
> - many build issues
>
> If the last 4 issues are not fixed in the next release 2.2,
> the driver must be removed.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] config: disable bnx2x driver
2015-07-28 17:16 [dpdk-dev] [PATCH] config: disable bnx2x driver Thomas Monjalon
2015-07-28 18:29 ` Stephen Hemminger
2015-07-28 21:17 ` Thomas Monjalon
@ 2015-07-28 21:38 ` Stephen Hemminger
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2015-07-28 21:38 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> This driver has too many issues:
> - too big
FYI - the DPDK version of the driver is already much smaller
than other OS. Still all versions seem to be bigger than necessary
but that is what vendor code looks like.
Driver LOC
bnx2x 37973
ixgbe 27017
i40e 25234
In FreeBSD
ixgbe 23834
bxe 160464
In Linux
ixgbe 25146
i40e 28753
bnx2x 55395
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-28 21:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-28 17:16 [dpdk-dev] [PATCH] config: disable bnx2x driver Thomas Monjalon
2015-07-28 18:29 ` Stephen Hemminger
2015-07-28 21:17 ` Thomas Monjalon
2015-07-28 21:38 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).