From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 66A90C622
 for <dev@dpdk.org>; Thu, 30 Jul 2015 02:34:05 +0200 (CEST)
Received: by pdbbh15 with SMTP id bh15so14215755pdb.1
 for <dev@dpdk.org>; Wed, 29 Jul 2015 17:34:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=cwFhs1rgehJknaKxP9vu+5GIo+eISi1UwFkZwFYoGg4=;
 b=dFQZwCmzMsHI8ctQ3oVxFtS8AzbbppH4qPPfr8EMGJZAd21ip9N2Btjaye0IaX+wFD
 2jH9LsQSI0/JiAOz7CEITz0FOgJbVQG3i8JuIyT1YVm6e8o64s2BrD++C7231RcfQmjN
 0d/PIIOVrOfL7j1cYn/8g8UvY/QDUaW8RYL2B77ljDa+hxGVlNNfwzmxgdrbKcpJZoT0
 Ru7GPx4EmAD8JOt/xwvL1d5/2C+o1+Muc2MWz5m4we4vlI4lNxNVeGqwkj48ipIBBvnE
 jyWe5d6nErzM5B9Bv8iQt2PyFuA4Lq53bfadDwrIHbRivg80pV+UB3w4Gg4XcLzxsXgb
 nrUw==
X-Gm-Message-State: ALoCoQmGiZ9lNh6Zz5ZsqucX2w8QQ9yHaUlRn6ERqa7TJjR9xm9i/AYSFsNfOiOoV/viU9OM//zJ
X-Received: by 10.70.1.7 with SMTP id 7mr100856462pdi.38.1438216444738;
 Wed, 29 Jul 2015 17:34:04 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id u16sm31929932pdl.71.2015.07.29.17.34.03
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 29 Jul 2015 17:34:04 -0700 (PDT)
Date: Wed, 29 Jul 2015 17:34:14 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150729173414.742917b4@urahara>
In-Reply-To: <2862234.7tZV48DKFc@xps13>
References: <1429034136-13482-1-git-send-email-stephen@networkplumber.org>
 <2862234.7tZV48DKFc@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: make rte_pci_probe void
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2015 00:34:05 -0000

On Mon, 20 Apr 2015 15:15:36 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-04-14 10:55, Stephen Hemminger:
> > Since rte_pci_probe always returns 0 or exits via rte_exit()
> > there is no point in having it return a value.
> > 
> > Just make it void
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Seems partially superseded by this patch:
> 	http://dpdk.org/dev/patchwork/patch/4347/
> 

The patch could be redone, but it would break ABI for no good
reason. Just drop it.