From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9E3F3C62C for ; Thu, 30 Jul 2015 02:35:21 +0200 (CEST) Received: by padck2 with SMTP id ck2so13734502pad.0 for ; Wed, 29 Jul 2015 17:35:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Ffumdr3AY1KViGkDyu7o6VhMSa169rWzss7CUugA+nI=; b=DsMzSwCtVaoEkIw4owuyogoPSvhl1o3mHJIjPgt6xh1pDa5gvJ9FqHjP4t4d2wU9tG IncQW7D4kTWQfN2t4WTHa2QRlnncXTY4rs5OL2NKxpTllxEV7/h5Dgvtnk1v3klzOIJ/ VY9z9+E/8+R3UOoihZ9IyxPNGrZqWkI1O3o/EtBX3OWrNY0rUVo3/OzEexr4qxpLr7xN 6AAFsKN/ZmH+P+/ykEWafjJ/Hm0QqSiSVAGTvnVvn3sNOXurZYuDcb+B6vREIpQRUrXh d+45PwVL2unOoaZVl36DHKnFFkFK/a3VozmqLezmSXoYAGuXNp+kiIWUhaKZiY/Ht8Ec yoIA== X-Gm-Message-State: ALoCoQlZW5PnDBNkv7UF8drTav2Eoiej478feDopiTQ7RIOgq6DGWvV+dFh9d5/YHFDt11oTQc9Z X-Received: by 10.66.236.70 with SMTP id us6mr99974414pac.39.1438216521082; Wed, 29 Jul 2015 17:35:21 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id nx1sm33779610pab.6.2015.07.29.17.35.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 17:35:20 -0700 (PDT) Date: Wed, 29 Jul 2015 17:35:30 -0700 From: Stephen Hemminger To: Bruce Richardson Message-ID: <20150729173530.1bdea317@urahara> In-Reply-To: <20150519102402.GD11036@bricha3-MOBL3> References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> <1429284934-3261-2-git-send-email-stephen@networkplumber.org> <20150519102402.GD11036@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 00:35:22 -0000 On Tue, 19 May 2015 11:24:03 +0100 Bruce Richardson wrote: > On Fri, Apr 17, 2015 at 08:35:33AM -0700, Stephen Hemminger wrote: > > Function always returned 0 and no one was checking anyway. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Bruce Richardson > > > --- > > lib/librte_eal/common/eal_common_log.c | 3 +-- > > lib/librte_eal/common/include/rte_log.h | 5 +---- > > 2 files changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c > > index ff44d23..3802f9c 100644 > > --- a/lib/librte_eal/common/eal_common_log.c > > +++ b/lib/librte_eal/common/eal_common_log.c > > @@ -158,14 +158,13 @@ rte_log_set_history(int enable) > > } > > > > /* Change the stream that will be used by logging system */ > > -int > > +void > > rte_openlog_stream(FILE *f) > > { > > if (f == NULL) > > rte_logs.file = default_log_stream; > > else > > rte_logs.file = f; > > - return 0; > > } > > > > /* Set global log level */ > > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h > > index f83a0d9..888ee19 100644 > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -110,11 +110,8 @@ extern FILE *eal_default_log_stream; > > * > > * @param f > > * Pointer to the stream. > > - * @return > > - * - 0 on success. > > - * - Negative on error. > > */ > > -int rte_openlog_stream(FILE *f); > > +void rte_openlog_stream(FILE *f); > > > > /** > > * Set the global log level. > > -- > > 2.1.4 > > Yes it should be void, but technically this is an ABI change. Please drop the patch.