From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0081.outbound.protection.outlook.com [65.55.169.81]) by dpdk.org (Postfix) with ESMTP id B23815A33 for ; Thu, 27 Aug 2015 06:09:02 +0200 (CEST) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.172.79.127) by DM2PR07MB958.namprd07.prod.outlook.com (10.141.98.150) with Microsoft SMTP Server (TLS) id 15.1.243.23; Thu, 27 Aug 2015 04:08:58 +0000 Date: Thu, 27 Aug 2015 09:38:41 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20150827040839.GA5223@localhost.localdomain> References: <1439901605-31164-1-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-3-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com> <1759749.jiktJN44xV@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1759749.jiktJN44xV@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.172.79.127] X-ClientProxiedBy: HKXPR03CA0055.apcprd03.prod.outlook.com (10.141.129.45) To DM2PR07MB958.namprd07.prod.outlook.com (10.141.98.150) X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB958; 2:KtOQCVUH2ETEI75lBEUU7T1K1Tcmm1vSyWXdyZbo1ZiuANNEivZOee25W8IuyHHM7MvVdupCPu2RM3DA+PzKd2yDe3oPr1RO/ivf+fV9qFiMwoCLGosLTHplfQBnvlKoteNV2VuOPn5ssL9n/NoGQgfJoiQ3GY29bV6suIox4jU=; 3:tGuRbJfqkJLcWcRbIA3Pye+oITUdJYkCoArcN4Vuoqk4E/yqHDNspnRDjcL5c9gFW2ZKxtw8UfyhILoedHy6OFHZwIRdsNGqt+e69ER2uynC6Ix3vuwZ5DwfFx9ZYVLnSqYX5kmxFVFXz1EE0qkA2w==; 25:MzM+nT3sp7zx/hRXF7zdXueWzYaV4E1O+JrdvDsRZEBl3enMBfvPbRN7ly0P4gflVd8b5nRhVTCLGJHJuW9Rjev6fuViuzqvVLV0FHZjtxCx9y5VSbA/fYDZC/6vk6n208x0pHTeAdG67DMuXJSEqSCZiCESm2PEy8jvi4W8lUDrKt/YvhJwfDCw6ZsTaEfGIzHA1uQbCLxZjqq65JN8XWph8R6GgvBKB59o6BPF859SM+oyNrzkYwW7BEorThTgVyCTiHVKNhwijAUlm8uCbg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB958; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB958; 20:HlfgIc7Bkm/VZYMCho+iPzfxvWQ4C+nm1neObQv4BNfSQa4Z+YIbxBnGObQP8dyJtXe6zeyh+U22zLhYTyos/vXwTvGxHV5k5S6t1DBVakyLhJxNlXKQS/fDMpiJfApLDDZCrSK969udH2bZrQKJhfRNBoXIFs+G37cEMx5OzfcLOOsSxYvpqimKOrmtJHlCcBrKXMv92Pf8iGLReLFJ9axvwpXBw0ZK/UvQxJ/bh3aGDAfdPi9C5ASTupocWYuhOzC1RbjMjJ/dBTBxAIPsb/L6cmFW4tMZa9RPuNiW50YVCq3mgg55UGc2aG3iXNsXmvFysNDnNFUZIQEZMpy8ahz11brhLlswEvDg5zSbTNRs3KHAEeL2o+wjwvo8MjUPCnUliJcgz+eklFxooQRkCE60wr4iu8x0cEskhjCIzo9yQnfECMLkusriDj02Oe0tTBhn/QNTG20uOGcRkZRTg0Rd7IwfHtH7Wv/DfdYNRcZ3zBNBusny92ljk+eRnESG3T8BxzX/nb3fOsYjNY/xlooWSn5H8yiKg424pj5uuRO1mCy2bYyIHYu3FS862miuarcnD2vmoN06gVuoDX019mlGXinjSzFA+4dQfWX/Znw=; 4:OPXe/pdfgCv2JW0YIx1nC+dBW0SmcPsTTANvxF8R/xTNNFUQxPcqsgBjfbLJmUJIbYlPKmfY/vE6S1wisfSMTd1QtqW2nfePzxkI9KzY9/dyrrENG1x6JqkoNT6eRi5o6ojno88acE1kPCO6+UPfG/2XNgiZOGg4S1UCOtB9nXWUE3uh0hwrnrfoyKLQT9IoSTC4eP3aihRwnw4g7oFPQnALPu//TMA0f8fZShXPZXwBtVAHxOzGJJV19VFMoW74k18FeVe4IZf8TCe9SiuDV/uZDS5V1ETMw5s874KPx9kSkeosICbgXDlmJqmJbHaS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:DM2PR07MB958; BCL:0; PCL:0; RULEID:; SRVR:DM2PR07MB958; X-Forefront-PRVS: 06818431B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(199003)(189002)(24454002)(377424004)(61506002)(68736005)(47776003)(81156007)(5001830100001)(5001860100001)(97736004)(77096005)(64706001)(50466002)(2950100001)(66066001)(4001540100001)(5004730100002)(46406003)(110136002)(33656002)(5001960100002)(93886004)(189998001)(5007970100001)(4001350100001)(97756001)(87976001)(46102003)(101416001)(50986999)(54356999)(77156002)(62966003)(86362001)(83506001)(76176999)(40100003)(105586002)(92566002)(23726002)(42186005)(122386002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR07MB958; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR07MB958; 23:XXdQQFHF3ZEPG1jjXkMSBwyIAf9HJjlNYCf0moyHqe?= =?us-ascii?Q?1b5vqDbBsP2ar8CdQr0UOfSAJqGsZ3iOdDlVXGx6y4z8tbZOi9NXV4pwgVIC?= =?us-ascii?Q?YAQhrWXA3hYV9TUxUIQIQiVtsufnBagwxA/HFnephl6tEEFmm3vwa1i/ydl1?= =?us-ascii?Q?JQ99OG1pADqXnCa+g7KOTrTpodsRkZ1L4kwoCoHzMXNzYlkRRm6UTNfy39bV?= =?us-ascii?Q?YfsdDso/+2V0+CAsK1LbJ7XDPDLVzWj2fqBechuPKHJ9jetKaTHJKpko+I2z?= =?us-ascii?Q?3zSvNV3lQVahgSSD0GFdxca3luRDtv3897U9Yug3btIOdroa0K5+rMd7qg/a?= =?us-ascii?Q?GM3tL6RcP8yzAM7Q48HCYV4FDjWAq5Db9KEy8Ir/EcSWngQhi8/QR0NBa+Js?= =?us-ascii?Q?tZM1SIWNWU95GpQEFy+FhsimCGyP4gxH84F1tpB0auojU8nsquPERooNhWiI?= =?us-ascii?Q?bflGvbUlPDfVxcrGLHQPRXFcvvDN+ik4Xubx2W2+R5dR7TtPib+IXU/bqSyG?= =?us-ascii?Q?1ASxLXly+7d9lDCjxMHin4h4HG4xUYDXClr1sjBSlbFpo0bVeaMQ8xvN6I86?= =?us-ascii?Q?EhEZkyDUHeIi0V4sfARAiGixd3vRHRr2QrlbsIJonoPawzXUk/H79M2fK4vV?= =?us-ascii?Q?lrJmMrW+4HrpN4AAvN8Qa6mSwUOyl9b3qOGFJP/PfpQ8c0yRbfdjl1K3POMP?= =?us-ascii?Q?ttyoYAu8AZ8R4sCxunshvjvyJipPTUfSyzkhfILTxxqTZrSbf9bq2q12acqr?= =?us-ascii?Q?ble5zxsLVZfjMBDoXZj57QUAi0ykVgCMhK3Y8uiKdSc+pVbGT/5SZYjUsZ9x?= =?us-ascii?Q?KYAcvnXtC4B9Y0Ag/TwS2CxBH8oR8Av/+VauvQ9Ou05RSJU8xkNQa86pRIXk?= =?us-ascii?Q?fd/q5+wMyzFd5HEviyBlCQ/85BZhtjcxZ2FAdRBo2RhdbaEjKVuIl9SrBfa9?= =?us-ascii?Q?+rRxc//LHfiddTyT5TEV9qr1oR2xhFVdtvG2h42dxwVZwXtxoQy7H43ScSVG?= =?us-ascii?Q?eKeP0hpEKPyEt5sqM15cb+KC7bxN2v0pyVlb5Lkmvr59c30U3XMbvzjB+yow?= =?us-ascii?Q?W7L4Tp2CrsCZGYmkNODVqSlji5SGkbv7yqdprVmQwqioQ3iBD1EMFaJIC5NR?= =?us-ascii?Q?Di6ia8HyVNNJRJkfWvMP+qeS4Za8kVAh0lSzv4nb9FAw1eEuh8Zld14+NcSR?= =?us-ascii?Q?J6ArImMVhFvDJqCpBpd6NU/U9y6rUh9YYADryKTZA9bhAIQwO01zAKOg=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB958; 5:zlLq52xnaD4U+Sl3GgA96O1HCSQP4YS+SoI6qmAW9CSxqXUZCTTIy5EbqlW0+zDjHy/o1q5k5mikQGgCfzYvINpEwbadzLcojCkV6gynhTFnwYhihLUI5AeulIGDYnRUMfe4HHKOFxPiTiPL7Kcphw==; 24:n4sEDfiFQ1P9aXVAjRVcRMBW13/Mflf0qAFWtFVIYMdkRrhb4UxX0pISgN9nkS7z6gRwqBjqrzO5suhwCg/YmaT9/JTxVO0fLURhxCIWFCI=; 20:UorshJG6C1ArxoAIr4Cn+3FC59IdmhPwBNpUNFGen8/6rsWlkYUjIsUYgUHhdkc709kD25pz+XLdE5dZHLiQKQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2015 04:08:58.3589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB958 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2015 04:09:03 -0000 On Tue, Aug 25, 2015 at 02:03:13PM +0200, Thomas Monjalon wrote: > 2015-08-18 18:10, Jerin Jacob: > > --- a/app/test/test_red.c > > +++ b/app/test/test_red.c > > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32) > > #ifdef __PIC__ > > asm volatile ( > > "mov %%ebx, %%edi\n" > > @@ -155,6 +156,7 @@ static inline void rdtsc_prof_start(struct rdtsc_prof *p) > > #else > > asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" ); > > #endif > > +#endif > > p->clk_start = rte_rdtsc(); > > The right fix would be to move that arch-specific code into an EAL abstraction. I agree. I thought the same. But I am not able to understand why 'cpuid' instruction used here without any input/output parameters. What is the role of 'cpuid' instruction in this specific function and what to abstract in eal ? >