From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id EFCDD591E for ; Fri, 28 Aug 2015 12:27:54 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZVGsu-0003Jw-55; Fri, 28 Aug 2015 06:27:53 -0400 Date: Fri, 28 Aug 2015 06:27:42 -0400 From: Neil Horman To: "John W. Linville" Message-ID: <20150828102742.GA3351@hmsreliant.think-freely.org> References: <1440695833-28778-1-git-send-email-linville@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440695833-28778-1-git-send-email-linville@tuxdriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -1.0 (-) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_eth_af_packet: refactor error handling to avoid NULL pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 10:27:55 -0000 On Thu, Aug 27, 2015 at 01:17:13PM -0400, John W. Linville wrote: > Coverity CID # 13321 > > Checking *internals != NULL before accessing req is not good enough, > because **internals is a function argument and the function doesn't > really know what is passed-in. We can close our eyes and ignore the > warning on the basis of controlling all the calling code, or we can > refactor the error exit to avoid the issue entirely... > > Signed-off-by: John W. Linville Acked-by: Neil Horman