From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 182818D86
 for <dev@dpdk.org>; Fri, 11 Sep 2015 21:18:04 +0200 (CEST)
Received: by pacex6 with SMTP id ex6so82814579pac.0
 for <dev@dpdk.org>; Fri, 11 Sep 2015 12:18:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=EGoTwGaE/xVazVO6RV+DLGJ3LBfHp5YR2G2ZDtbCB0g=;
 b=cQOAVRzIy9czKx9VUEH9EQj47vzy1pX+56Iav5SMQjPbNLBS7q70eAm4qC4GdROaaQ
 wKxiAsZoz8jyfH7K/vsPgJPcZKfV+yudfi3MEtaCZ2YtLWFdDM4zN1fIL+3f9oJgIQ9+
 cJQFixAXDcLE4uAX3DwDmeIsu0vsiaIMHgM/wecBE786nw+qUmcP8DeSvWTN59T88iVu
 4cFvvz3/vunlGU10eYqVSNiJzvxYYpcMz9j0xcE/WqwAetPd5A1honnPOM7XSwv8DNji
 HvFSR5YMJaT/dsG+eYdw9CjmllDvsc68OIslgDXnsEQN7qVr+IAf7HxwTPdg69tV53zg
 E9gg==
X-Gm-Message-State: ALoCoQnprp0Zw9QR3fJxHM9Wh/isdx93PerLB4CPAuRdyQ1MPCfMhzsQRKIdD8OmhmyUgzTxyFkd
X-Received: by 10.66.255.42 with SMTP id an10mr736750pad.107.1441999083230;
 Fri, 11 Sep 2015 12:18:03 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id xs7sm1838384pab.4.2015.09.11.12.18.02
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 11 Sep 2015 12:18:03 -0700 (PDT)
Date: Fri, 11 Sep 2015 12:18:05 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Message-ID: <20150911121805.310fe1ed@urahara>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478BAA2E@IRSMSX108.ger.corp.intel.com>
References: <1440780599-14851-1-git-send-email-stephen@networkplumber.org>
 <1440780599-14851-3-git-send-email-stephen@networkplumber.org>
 <3EB4FA525960D640B5BDFFD6A3D89126478BAA2E@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] rte_sched: remove useless bitmap_free
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2015 19:18:04 -0000


> Hi Steve,
> 
> I agree these functions are not doing much at the moment, but I would like to keep them for the reasons below:
> 
> 1. There might be people using them, and we do not want to break their code. Removing them is an ABI change.
> 
> 2. Although they are just placeholders for now, we might need to add more functionality to them going forward, as the implementation evolves. I don't want to change the API now by removing them, and change the API later when we need to add them back. Generally, I think it is good practice to have free functions.

The source code base is not a code repository for unused and dead code!
If you need to keep things, either get them out of previous history with git
or keep them out of tree.

Also have a number of patches to remove all #ifdef code that is dead
in QoS now.