From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mst@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id AFCF6E72
 for <dev@dpdk.org>; Mon, 21 Sep 2015 11:02:24 +0200 (CEST)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 by mx1.redhat.com (Postfix) with ESMTPS id 03DF2425A3;
 Mon, 21 Sep 2015 09:02:23 +0000 (UTC)
Received: from redhat.com (ovpn-116-114.ams2.redhat.com [10.36.116.114])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id
 t8L92LS9010524; Mon, 21 Sep 2015 05:02:22 -0400
Date: Mon, 21 Sep 2015 12:02:20 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20150921120117-mutt-send-email-mst@redhat.com>
References: <1442589061-19225-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1442589061-19225-6-git-send-email-yuanhan.liu@linux.intel.com>
 <20150920123021-mutt-send-email-mst@redhat.com>
 <20150921022252.GO2339@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150921022252.GO2339@yliu-dev.sh.intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 resend 05/12] vhost: add
 VHOST_USER_SET_VRING_ENABLE message
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Sep 2015 09:02:24 -0000

On Mon, Sep 21, 2015 at 10:22:52AM +0800, Yuanhan Liu wrote:
> On Sun, Sep 20, 2015 at 12:37:35PM +0300, Michael S. Tsirkin wrote:
> > On Fri, Sep 18, 2015 at 11:10:54PM +0800, Yuanhan Liu wrote:
> > > From: Changchun Ouyang <changchun.ouyang@intel.com>
> > > 
> > > This message is used to enable/disable a specific vring queue pair.
> > > The first queue pair is enabled by default.
> > > 
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > ---
> [snip...]
> > >  void
> > >  user_destroy_device(struct vhost_device_ctx ctx)
> > >  {
> > 
> > It might be a good idea to flush any packets being processed
> > on relevant cores at this point.
> 
> They are offloaded to the application (examples/vhost/vhost-switch in
> this case).
> 
> user_destroy_device will invoke the application's "destroy_device()"
> callback in the end, which, in our case, will set "remove" flag. The
> core worker will then drain and free the RX queue and free TX queue
> once the "remove" flag is set.
> 
> 	--yliu


Oh, I really meant user_set_vring_enable.
Sorry about the confusion.

-- 
MST