From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH] virtio: virtio ring layout optimization and vectorization rx
Date: Tue, 22 Sep 2015 15:55:23 -0700 [thread overview]
Message-ID: <20150922155523.5f6fab96@urahara> (raw)
In-Reply-To: <4377815.VgSsvvaXDb@xps13>
On Tue, 22 Sep 2015 15:37:13 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-09-22 09:29, Xie, Huawei:
> > On 9/22/2015 4:38 PM, Thomas Monjalon wrote:
> > > I thought it was clear we must avoid #ifdef for configuration.
> > > Please check how to add a runtime flag.
> > > Or better: keep only one path which works everywhere and well optimized.
> >
> > Thomas, i have this in mind when i am developing this feature and i plan
> > to discuss this with you. In theory, the best solution would be using
> > run time flag and the result would be normally we always choose the
> > optimized path.
> > The situation in real world is, in my mind, this feature isn't mature
> > enough(Of course this doesn't mean it has known issues). One good
> > solution in kernel community is experimental features.
> > Could we also have experimental/development tag? I would like to put
> > this as experimental/development feature temporarily, turn it off by
> > default and continue to improve it.
>
> I think it is a rework, not an experimental feature.
>
> > The advantage is we have it in tree and every developers could pull it
> > and help improve it. Also, it is the base for continuous vhost
> > optimization. We should have a performance optimized driver for the
> > device side optimization.
>
> If there are some acceptance problem, it can be solved on the list.
> If there are some bugs after integration, it can be fixed before the release,
> as there are some validation and non-regression tests.
>
> If the new Rx/Tx code can replace the old one, please replace it.
> If the use cases are different, please use a runtime flag.
> It it is not ready, please do more tests and re-submit later.
>
> By the way, thanks for your work.
Agree with Thomas.
Any feature should be always on, and negotiated by existing virtio
feature bits.
next prev parent reply other threads:[~2015-09-22 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:17 Huawei Xie
2015-09-22 8:37 ` Thomas Monjalon
2015-09-22 9:29 ` Xie, Huawei
2015-09-22 13:37 ` Thomas Monjalon
2015-09-22 22:55 ` Stephen Hemminger [this message]
2015-09-24 18:03 ` [dpdk-dev] [RFC PATCH v2] virtio ring layout optimization and vectorization Huawei Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922155523.5f6fab96@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).