From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1D4CD8D93 for ; Thu, 24 Sep 2015 15:58:58 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 24 Sep 2015 06:58:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,581,1437462000"; d="scan'208";a="812062235" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.60]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2015 06:58:33 -0700 Date: Thu, 24 Sep 2015 22:01:00 +0800 From: Yuanhan Liu To: Thomas Monjalon Message-ID: <20150924140100.GD2326@yliu-dev.sh.intel.com> References: <1441776876-14595-1-git-send-email-yuanhan.liu@linux.intel.com> <1441776876-14595-4-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/4 v2] vhost: fix wrong usage of eventfd_t X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 13:58:59 -0000 Hi Thomas, Would you consider to apply these 4 patches please? The 4th patch affects quite many lines of code, and the sooner we apply it, the fewer chance it will introduce conflicts for later patches. Thanks. --yliu On Wed, Sep 09, 2015 at 05:44:51AM +0000, Xie, Huawei wrote: > > Acked-by: Huawei Xie > > Thanks for fixing this. > > On 9/9/2015 1:32 PM, Yuanhan Liu wrote: > > According to eventfd man page: > > > > typedef uint64_t eventfd_t; > > > > int eventfd_read(int fd, eventfd_t *value); > > int eventfd_write(int fd, eventfd_t value); > > > > eventfd_t is defined for the second arg(value), but not for fd. > > > > Here I redefine those fd fields to `int' type, which also removes > > the redundant (int) cast. And as the man page stated, we should > > cast 1 to eventfd_t type for eventfd_write(). > > > > v2: cast 1 with `eventfd_t' type. > > > > Signed-off-by: Yuanhan Liu > > --- > > examples/vhost/main.c | 6 ++--- > > lib/librte_vhost/rte_virtio_net.h | 4 ++-- > > lib/librte_vhost/vhost_rxtx.c | 6 ++--- > > lib/librte_vhost/vhost_user/virtio-net-user.c | 16 +++++++------- > > lib/librte_vhost/virtio-net.c | 32 +++++++++++++-------------- > > 5 files changed, 32 insertions(+), 32 deletions(-) > >