From: Bruce Richardson <bruce.richardson@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] hash: fix incorrect lookup if key is all zero
Date: Mon, 28 Sep 2015 11:29:48 +0100 [thread overview]
Message-ID: <20150928102948.GA27944@bricha3-MOBL3> (raw)
In-Reply-To: <1442485848-25401-1-git-send-email-pablo.de.lara.guarch@intel.com>
On Thu, Sep 17, 2015 at 11:30:48AM +0100, Pablo de Lara wrote:
> If user has not added an all zero key in the hash table,
> and tries to look it up, it results in an incorrect hit,
> as dummy slot in the key table has all zero as well.
>
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> Changes in v2:
> - Include Fixes: tag in commit message
>
> doc/guides/rel_notes/release_2_2.rst | 5 +++++
> lib/librte_hash/rte_cuckoo_hash.c | 27 +++++++++++++++++----------
> 2 files changed, 22 insertions(+), 10 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2015-09-28 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 9:04 [dpdk-dev] [PATCH] " Pablo de Lara
2015-09-17 10:14 ` Thomas Monjalon
2015-09-17 10:30 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2015-09-28 10:29 ` Bruce Richardson [this message]
2015-11-04 0:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928102948.GA27944@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).