From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AF790374F for ; Mon, 28 Sep 2015 12:29:54 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 28 Sep 2015 03:29:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,602,1437462000"; d="scan'208";a="653556666" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by orsmga003.jf.intel.com with SMTP; 28 Sep 2015 03:29:51 -0700 Received: by (sSMTP sendmail emulation); Mon, 28 Sep 2015 11:29:49 +0025 Date: Mon, 28 Sep 2015 11:29:48 +0100 From: Bruce Richardson To: Pablo de Lara Message-ID: <20150928102948.GA27944@bricha3-MOBL3> References: <1442480658-4741-1-git-send-email-pablo.de.lara.guarch@intel.com> <1442485848-25401-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442485848-25401-1-git-send-email-pablo.de.lara.guarch@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] hash: fix incorrect lookup if key is all zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2015 10:29:55 -0000 On Thu, Sep 17, 2015 at 11:30:48AM +0100, Pablo de Lara wrote: > If user has not added an all zero key in the hash table, > and tries to look it up, it results in an incorrect hit, > as dummy slot in the key table has all zero as well. > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") > > Signed-off-by: Pablo de Lara > --- > Changes in v2: > - Include Fixes: tag in commit message > > doc/guides/rel_notes/release_2_2.rst | 5 +++++ > lib/librte_hash/rte_cuckoo_hash.c | 27 +++++++++++++++++---------- > 2 files changed, 22 insertions(+), 10 deletions(-) > Acked-by: Bruce Richardson