From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate3.asicdesigners.com (stargate.chelsio.com [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id 2E76B2A1A for ; Mon, 28 Sep 2015 20:53:09 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id t8SIr4lW030115; Mon, 28 Sep 2015 11:53:05 -0700 Date: Tue, 29 Sep 2015 00:23:02 +0530 From: Rahul Lakkireddy To: Bernard Iremonger Message-ID: <20150928185301.GA12770@scalar.blr.asicdesigners.com> References: <1443445418-18498-1-git-send-email-bernard.iremonger@intel.com> <1443445418-18498-17-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443445418-18498-17-git-send-email-bernard.iremonger@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: dev@dpdk.org, Felix Marti , Kumar Sanghvi , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH 16/20] cxgbe: copy pci device info to eth_dev data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2015 18:53:09 -0000 Hi Bernard, On Monday, September 09/28/15, 2015 at 14:03:34 +0100, Bernard Iremonger wrote: > Signed-off-by: Bernard Iremonger > --- > drivers/net/cxgbe/cxgbe_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c > index 478051a..2fa2cc3 100644 > --- a/drivers/net/cxgbe/cxgbe_ethdev.c > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > @@ -2,6 +2,8 @@ > * BSD LICENSE > * > * Copyright(c) 2014-2015 Chelsio Communications. > + * Copyright(c) 2015 Intel Corporation. > + * > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -744,6 +746,9 @@ static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev) > return 0; > > pci_dev = eth_dev->pci_dev; > + > + rte_eth_copy_dev_info(eth_dev, pci_dev); > + > snprintf(name, sizeof(name), "cxgbeadapter%d", eth_dev->data->port_id); > adapter = rte_zmalloc(name, sizeof(*adapter), 0); > if (!adapter) > -- > 1.9.1 > Out of curiosity, do you really need to add Intel copyright on top of source file for a 3 line change in source file? I see that you have done the same for cisco, mellanox, broadcom and other vendors as well. I don't claim to understand Copyright very well. However, I have seen in other open community projects like kernel.org where people many times do significant change in someone else's code and yet, don't normally add their own copyright to source files. Care to explain what is the intention here with addition of Intel Copyright statement? Thanks, Rahul