From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 766568D36
 for <dev@dpdk.org>; Wed, 30 Sep 2015 19:44:51 +0200 (CEST)
Received: by pacex6 with SMTP id ex6so47017566pac.0
 for <dev@dpdk.org>; Wed, 30 Sep 2015 10:44:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=D8auISP2B6l+kOOXxvtugaAuLKQ+/gq4He2S1yMjass=;
 b=gMI37bME1LZJcimPbY79PEe0amNrrxJvPR81JjdA+m8ifjzgHgGBNmjNTIccijaLUK
 9nzVOf9S4ieWj8RImXF8oj+PepImcoipgzxDpth044Z54zGU8gF3jxHiDHrlSQT7h/bp
 uyMd1QGlLsCbNBO11NP3SIqPNj1SLiXaOUtFUhYfu3JRIf7rj30PzpaoIDouYkzbDkNA
 eBjICjRmvgNtqIW62+mARZ6LXu8P+PXCwncFVGMMXSV/a36Kg0aZoaIGadVpUTfzFDsU
 uo/M2p4vJk78CjM6xegAqPOYhKlpAIXbUe/huDqdWB+4odIrMUyFCfZnu933EKwkfNJ0
 p+Jg==
X-Gm-Message-State: ALoCoQlbl25pfBOC/sLSHu1kDR2kj0Cy0heG6cBJ+s8o3jDwdQu9nigY3pUO5x5fJjmGAsEe+WkX
X-Received: by 10.66.150.105 with SMTP id uh9mr6351688pab.78.1443635090845;
 Wed, 30 Sep 2015 10:44:50 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id fu4sm1842183pbb.59.2015.09.30.10.44.50
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 30 Sep 2015 10:44:50 -0700 (PDT)
Date: Wed, 30 Sep 2015 10:44:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Harry van Haaren <harry.van.haaren@intel.com>
Message-ID: <20150930104457.5ad45e08@urahara>
In-Reply-To: <1443606022-13581-5-git-send-email-harry.van.haaren@intel.com>
References: <1443606022-13581-1-git-send-email-harry.van.haaren@intel.com>
 <1443606022-13581-5-git-send-email-harry.van.haaren@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 04/11] virtio: add xstats() implementation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Sep 2015 17:44:52 -0000

On Wed, 30 Sep 2015 10:40:15 +0100
Harry van Haaren <harry.van.haaren@intel.com> wrote:

> +/* [rt]x_qX_ is prepended to the name string here */
> +static const struct rte_virtio_xstats_name_off rte_virtio_q_stat_strings[] = {
> +	{"packets", offsetof(struct virtqueue, packets)},
> +	{"bytes", offsetof(struct virtqueue, bytes)},
> +	{"errors", offsetof(struct virtqueue, errors)},
> +}

I don't see the point of this. The point of xstats is to tell the application
about statistics not available through other means.

These stats should be available already in the per queue stats.