From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id EE6708D99 for ; Wed, 30 Sep 2015 15:19:07 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZhHHf-0004Gh-9Z; Wed, 30 Sep 2015 09:19:06 -0400 Date: Wed, 30 Sep 2015 09:18:53 -0400 From: Neil Horman To: Bernard Iremonger Message-ID: <20150930131853.GB32524@hmsreliant.think-freely.org> References: <1443445418-18498-1-git-send-email-bernard.iremonger@intel.com> <1443445418-18498-3-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443445418-18498-3-git-send-email-bernard.iremonger@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -1.0 (-) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 13:19:08 -0000 > +} > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index fa06554..9cd262b 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1635,8 +1635,23 @@ struct rte_eth_dev_data { > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > + enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > + int numa_node; > + const char *drv_name; > }; > Unrelated to my other questions on this code: Is rte_eth_dev_data ever allocation by any applications? If so, this will have to go through the ABI process. I don't think it is, but I wanted to ask to be sure Neil > +/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */ > +#define RTE_ETH_DEV_DRV_NEED_MAPPING RTE_PCI_DRV_NEED_MAPPING > +/** Device needs to be unbound even if no module is provided */ > +#define RTE_ETH_DEV_DRV_FORCE_UNBIND RTE_PCI_DRV_FORCE_UNBIND > +/** Device supports link state interrupt */ > +#define RTE_ETH_DEV_INTR_LSC RTE_PCI_DRV_INTR_LSC > +/** Device supports detaching capability */ > +#define RTE_ETH_DEV_DETACHABLE RTE_PCI_DRV_DETACHABLE > +/** Device is a bonded device */ > +#define RTE_ETH_DEV_BONDED 0x0020 > + > /** > * @internal > * The pool of *rte_eth_dev* structures. The size of the pool > -- > 1.9.1 > >