From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4 v2] vhost: fix wrong usage of eventfd_t
Date: Thu, 8 Oct 2015 14:29:56 +0800 [thread overview]
Message-ID: <20151008062956.GD3115@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1819196.IhieQvLMLL@xps13>
On Sun, Sep 27, 2015 at 09:35:35PM +0200, Thomas Monjalon wrote:
> 2015-09-27 08:17, Yuanhan Liu:
> > On Fri, Sep 25, 2015 at 02:44:11PM +0200, Thomas Monjalon wrote:
> > > - make the first email the child of the previous version
> >
> > I'm wondering how could you do that, with git-send-email.
>
> It can be checked in http://dpdk.org/dev#send:
> --in-reply-to <Message-ID of the previous patch>
Thanks for the tip (and sorry for the late reply).
I see that it might be helpful, especially when it's a single patch or
small patch set. But I doubt it's helpful if it's a large patch set,
and especially when there are quite many comments. Linking a large
thread to another huge thread will make it messy, making it harder for
review, IMO. Or, am I wrong?
--yliu
>
> The message id is in the mail headers.
prev parent reply other threads:[~2015-10-08 6:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 5:34 [dpdk-dev] [PATCH 1/4] vhost: remove redundant ; Yuanhan Liu
2015-09-09 5:34 ` [dpdk-dev] [PATCH 2/4] vhost: fix typo Yuanhan Liu
2015-09-09 5:34 ` [dpdk-dev] [PATCH 3/4] vhost: get rid of duplicate code Yuanhan Liu
2015-09-09 5:34 ` [dpdk-dev] [PATCH 4/4 v2] vhost: fix wrong usage of eventfd_t Yuanhan Liu
2015-09-09 5:44 ` Xie, Huawei
2015-09-24 14:01 ` Yuanhan Liu
2015-09-25 12:44 ` Thomas Monjalon
2015-09-25 12:59 ` Thomas Monjalon
2015-09-27 0:17 ` Yuanhan Liu
2015-09-27 19:35 ` Thomas Monjalon
2015-10-08 6:29 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008062956.GD3115@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).