From: Stephen Hemminger <stephen@networkplumber.org>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"changchun.ouyang@intel.com" <changchun.ouyang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: use any layout on transmit
Date: Mon, 19 Oct 2015 10:19:34 -0700 [thread overview]
Message-ID: <20151019101934.6f3b92f9@xeon-e3> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B4B12CC68@SHSMSX101.ccr.corp.intel.com>
On Mon, 19 Oct 2015 16:28:30 +0000
"Xie, Huawei" <huawei.xie@intel.com> wrote:
> "When using legacy interfaces, transitional drivers which have not
> negotiated VIRTIO_F_ANY_LAYOUT
> MUST use a single descriptor for the struct virtio_net_hdr on both
> transmit and receive, with the
> network data in the following descriptors."
>
> I think we shouldn't assume that virtio header descriptor uses a
> separate descriptor. It could be with data. Virtio RX(and dpdk vhost)
> actually is implemented like this before, i.e, i thought this should be
> inherent but not a feature.
> Is the current RX implementation wrong?
I believe current RX is ok, the any layout refers more to what is
handed to the host on transmit. Rusty said something like
"any sane implementation would work with contiguous buffer"
but the standard couldn't assume sanity!
next prev parent reply other threads:[~2015-10-19 17:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 5:16 [dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements Stephen Hemminger
2015-10-19 5:16 ` [dpdk-dev] [PATCH 1/5] virtio: clean up space checks on xmit Stephen Hemminger
2015-10-19 8:02 ` Xie, Huawei
2015-10-19 15:48 ` Stephen Hemminger
2015-10-19 16:27 ` Xie, Huawei
2015-10-19 5:16 ` [dpdk-dev] [PATCH 2/5] virtio: don't use unlikely for normal tx stuff Stephen Hemminger
2015-10-19 5:16 ` [dpdk-dev] [PATCH 3/5] virtio: use indirect ring elements Stephen Hemminger
2015-10-19 13:19 ` Xie, Huawei
2015-10-19 15:47 ` Stephen Hemminger
2015-10-19 16:18 ` Xie, Huawei
2015-10-30 18:01 ` Thomas Monjalon
2015-10-19 5:16 ` [dpdk-dev] [PATCH 4/5] virtio: use any layout on transmit Stephen Hemminger
2015-10-19 16:28 ` Xie, Huawei
2015-10-19 16:43 ` Stephen Hemminger
2015-10-19 16:56 ` Xie, Huawei
2015-10-26 23:47 ` Stephen Hemminger
2015-10-19 17:19 ` Stephen Hemminger [this message]
2015-10-19 5:16 ` [dpdk-dev] [PATCH 5/5] virtio: optimize transmit enqueue Stephen Hemminger
2015-10-20 1:48 ` Xie, Huawei
2015-10-21 13:18 ` [dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements Thomas Monjalon
2015-10-22 10:38 ` Xie, Huawei
2015-10-22 12:13 ` Xie, Huawei
2015-10-22 16:04 ` Stephen Hemminger
2015-10-23 9:00 ` Xie, Huawei
2015-10-26 23:52 ` Stephen Hemminger
2015-10-27 1:56 ` Xie, Huawei
2015-10-27 2:23 ` Stephen Hemminger
2015-10-27 2:38 ` Xie, Huawei
2015-10-26 14:05 ` Xie, Huawei
2016-01-05 8:10 ` Xie, Huawei
2016-01-06 12:03 ` Thomas Monjalon
2016-01-14 13:49 ` Xie, Huawei
2016-03-04 6:18 ` Xie, Huawei
2016-03-04 18:17 ` Stephen Hemminger
2016-03-08 1:38 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019101934.6f3b92f9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).