DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <btw@mail.ustc.edu.cn>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, dprovan@bivio.net
Subject: Re: [dpdk-dev] [PATCH] eal: don't reset getopt lib
Date: Mon, 19 Oct 2015 21:15:08 +0800	[thread overview]
Message-ID: <20151019131508.GA3867@dell> (raw)
In-Reply-To: <20151019103641.GA13936@bricha3-MOBL3>

On Mon, Oct 19, 2015 at 11:36:41AM +0100, Bruce Richardson wrote:
> On Thu, Oct 15, 2015 at 07:46:04PM +0800, Tiwei Bie wrote:
> > Someone may need to call rte_eal_init() with a fake argc/argv array
> > in the middle of using getopt() to parse its own unrelated argc/argv
> > parameters. So getopt lib shouldn't be reset by rte_eal_init().
> > 
> > Now eal will always save optind, optarg and optopt (and optreset on
> > FreeBSD) at the beginning, initialize optind (and optreset on FreeBSD)
> > to 1 before calling getopt_long(), then restore all values after.
> 
> This patch looks good overall. Minor comment inline below.
> 

Thanks for review! :-)

Best regards,
Tiwei Bie

  reply	other threads:[~2015-10-19 13:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 11:46 Tiwei Bie
2015-10-15 16:22 ` Don Provan
2015-10-16  2:25   ` Tiwei Bie
2015-10-19 10:36 ` Bruce Richardson
2015-10-19 13:15   ` Tiwei Bie [this message]
2015-10-19 13:13 ` [dpdk-dev] [PATCH v2] " Tiwei Bie
2015-10-19 13:16   ` Bruce Richardson
2015-10-21  5:33     ` David Marchand
2015-10-21  6:17       ` Tiwei Bie
2015-11-04 22:21       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019131508.GA3867@dell \
    --to=btw@mail.ustc.edu.cn \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dprovan@bivio.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).