From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8FCA58E9D for ; Tue, 20 Oct 2015 10:00:16 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 20 Oct 2015 01:00:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="831020172" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2015 01:00:14 -0700 Date: Tue, 20 Oct 2015 16:00:20 +0800 From: Yuanhan Liu To: Thomas Monjalon Message-ID: <20151020080020.GW3115@yliu-dev.sh.intel.com> References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com> <2143283.gKIdjTGCRD@xps13> <20151020072327.GV3115@yliu-dev.sh.intel.com> <4759700.UeY5nRH9Wr@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4759700.UeY5nRH9Wr@xps13> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 08:00:17 -0000 On Tue, Oct 20, 2015 at 09:27:37AM +0200, Thomas Monjalon wrote: > 2015-10-20 15:23, Yuanhan Liu: > > On Tue, Oct 20, 2015 at 09:07:49AM +0200, Thomas Monjalon wrote: > > > 2015-10-09 13:46, Yuanhan Liu: > > > > From: Changchun Ouyang > > > > > > > > The old code adjusts the config bytes we want to read depending on > > > > what kind of features we have, but we later cast the entire buf we > > > > read with "struct virtio_net_config", which is obviously wrong. > > > > > > When describing a bug, it is important to explain what is the consequence, > > > i.e. which use case is failing. If it is only to prepare the new feature, > > > it is better to clearly state that the bug had no impact until now. > > > > > > And as usual, the "fix" word in the title and the "Fixes" tag are required. > > > > What's the right way supposed to use "Fixes" tag, BTW? Checking the git > > hisotry, I saw something like: > > > > Fixes: $commit_hash ($commit_log). > > In http://dpdk.org/dev, this git alias is recommended: > fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' Thanks for the tip. > > > Which basically means it's a regression fix. However, in this case, it's > > more than like a bug, but not a regression. > > Referencing the original commit (introducing the bug) makes it clear. Okay. --yliu