From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 6A7568E78 for ; Wed, 21 Oct 2015 06:45:02 +0200 (CEST) Received: by pacfv9 with SMTP id fv9so44302770pac.3 for ; Tue, 20 Oct 2015 21:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Fb6kPwgJ1zhDwg1GrBPlo9hCbWgj2BZCvB5e4VjNSUQ=; b=P5StXZ5ygOHwMHYnZRBjqBHXzdcMl3iMWnNv6t9CAc4rQr59fm7JjgVBy4xcLE2MRO zS8SG0mAaTGwWHBvKGT1WngJQE37fc0oiQJqbktvhb57ixHjVzeTd7oxv7I7lYSuzyiX r/63hcUAz15yWw7pVttJG1aPnFucNB+q1XMtDQDfUoidwxjHb/vcgpp96u6JK6haT8lc OA630eDT8jdGOVlkmqMJVszw3u23xPgiV3qUbxxD9/QAiY4WTW4DwKJb1ocO/+0D5kfD bxtkLJ6LW093jjjpHYHFwWSwm4uFElgPMegZNOfpvfw6HEicWkOpglhu6MTxOaHZqbUE bFhw== X-Gm-Message-State: ALoCoQn/kjqbWtPW+WGdLc8IsJB3imnW7l3iQ1itfcjMCqL8kMCK4F7EiLTvPTcAq5GiTqU34l+C X-Received: by 10.68.216.193 with SMTP id os1mr8159780pbc.110.1445402701868; Tue, 20 Oct 2015 21:45:01 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id oo2sm6587705pbb.86.2015.10.20.21.45.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 21:45:01 -0700 (PDT) Date: Tue, 20 Oct 2015 21:45:12 -0700 From: Stephen Hemminger To: Yuanhan Liu Message-ID: <20151020214512.09e3cebe@xeon-e3> In-Reply-To: <1445399294-18826-4-git-send-email-yuanhan.liu@linux.intel.com> References: <1445399294-18826-1-git-send-email-yuanhan.liu@linux.intel.com> <1445399294-18826-4-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v7 3/8] vhost: vring queue setup for multiple queue support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 04:45:02 -0000 On Wed, 21 Oct 2015 11:48:09 +0800 Yuanhan Liu wrote: > struct virtio_net { > - struct vhost_virtqueue *virtqueue[VIRTIO_QNUM]; /**< Contains all virtqueue information. */ > + struct vhost_virtqueue *virtqueue[VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX]; /**< Contains all virtqueue information. */ > struct virtio_memory *mem; /**< QEMU memory and memory region information. */ Since vhost_virtqueue takes up space, why not put it at end of array, that way offsets are smaller and all the early fields will be in adjacent cache lines.