From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
Date: Fri, 23 Oct 2015 09:03:25 -0700 [thread overview]
Message-ID: <20151023090325.3a83fa0c@xeon-e3> (raw)
In-Reply-To: <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com>
On Fri, 23 Oct 2015 17:53:25 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> +
> +# override default Linux options
> +options="$options --max-line-length=$length"
> +options="$options --show-types"
> +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\
> +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL"
Please keep some of these:
PARENTHESIS_ALIGNMENT
LINUX_VERSION_CODE
COMPLEX_MACRO
All of these are indications of problems in code.
next prev parent reply other threads:[~2015-10-23 16:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:53 [dpdk-dev] [PATCH 0/2] more basic tests Thomas Monjalon
2015-10-23 15:53 ` [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-10-23 16:03 ` Stephen Hemminger [this message]
2015-10-23 16:34 ` Thomas Monjalon
2015-10-23 16:56 ` Stephen Hemminger
2015-10-23 16:58 ` Stephen Hemminger
2015-10-23 20:27 ` Thomas Monjalon
2015-10-29 12:17 ` Bruce Richardson
2015-10-29 12:33 ` David Marchand
2015-10-29 13:03 ` Thomas Monjalon
2015-10-29 13:24 ` Bruce Richardson
2015-10-29 13:34 ` Thomas Monjalon
2015-10-29 13:48 ` Bruce Richardson
2015-10-29 13:54 ` David Marchand
2015-10-29 13:57 ` Thomas Monjalon
2015-10-30 16:16 ` Bruce Richardson
2015-10-30 16:23 ` Thomas Monjalon
2015-11-02 10:28 ` Van Haaren, Harry
2015-11-02 10:33 ` Bruce Richardson
2015-10-23 15:53 ` [dpdk-dev] [PATCH 2/2] scripts: add build tests Thomas Monjalon
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-11-24 16:33 ` Bruce Richardson
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 2/2] scripts: add build tests Thomas Monjalon
2015-11-24 17:49 ` Mcnamara, John
2015-11-24 18:14 ` Thomas Monjalon
2015-12-03 17:39 ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023090325.3a83fa0c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).