From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 6010EC4EA
 for <dev@dpdk.org>; Fri, 23 Oct 2015 12:01:19 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 23 Oct 2015 03:01:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="833324491"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.66])
 by orsmga002.jf.intel.com with SMTP; 23 Oct 2015 03:01:16 -0700
Received: by  (sSMTP sendmail emulation); Fri, 23 Oct 2015 11:01:15 +0025
Date: Fri, 23 Oct 2015 11:01:15 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Message-ID: <20151023100115.GB8464@bricha3-MOBL3>
References: <1443531824-22767-2-git-send-email-jing.d.chen@intel.com>
 <1445507104-22563-1-git-send-email-jing.d.chen@intel.com>
 <1445507104-22563-2-git-send-email-jing.d.chen@intel.com>
 <20151022085840.1d082e75@xeon-e3>
 <4341B239C0EFF9468EE453F9E9F4604D02AE290A@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D02AE290A@shsmsx102.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 10:01:19 -0000

On Fri, Oct 23, 2015 at 08:39:56AM +0000, Chen, Jing D wrote:
> Hi, Stephen,
> 
> Best Regards,
> Mark
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Thursday, October 22, 2015 11:59 PM
> > To: Chen, Jing D
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file
> > 
> > On Thu, 22 Oct 2015 17:44:49 +0800
> > "Chen Jing D(Mark)" <jing.d.chen@intel.com> wrote:
> > 
> > > +#ifndef __INTEL_COMPILER
> > > +#pragma GCC diagnostic ignored "-Wcast-qual"
> > > +#endif
> > 
> > Since this is new code, can't you make it work correctly
> > with Gcc. Rather than turning off a useful diagnostic.
> 
> This macro is necessary for later SSE functions or I'll have to add some
> Un-necessary cast to avoid compile failure.
> 
> I can add it in later patch. But it will have to show up anyway, right? 

Actually, casting won't make the warnings go away either. You'll always get a
warning about removing the volatile from the structure members when you pass
them to the intrinsic functions. Only option is to temporarily disable the warning
[or else write your own versions of the intrinsics that do support volatiles :-)]

/Bruce