Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Oct 29, 2015 at 02:02:50PM +0800, Helin Zhang wrote:
> The default input set of fields of a received packet are loaded from
> firmware, which cannot be modified even users want to use different
> fields for RSS or flow director. Here adds more flexibilities of
> selecting packet fields for hash calculation or flow director for
> users.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c  | 742 ++++++++++++++++++++++++++++++++++++++++
>  drivers/net/i40e/i40e_ethdev.h  |   7 +
>  drivers/net/i40e/i40e_fdir.c    |  31 ++
>  lib/librte_ether/rte_eth_ctrl.h | 114 +++++-
>  4 files changed, 890 insertions(+), 4 deletions(-)
> 
<snip>
> @@ -672,6 +776,8 @@ struct rte_eth_hash_filter_info {
>  		uint8_t enable;
>  		/** Global configurations of hash filter */
>  		struct rte_eth_hash_global_conf global_conf;
> +		/** Global configurations of hash filter input set */
> +		struct rte_eth_input_set_conf input_set_conf;
>  	} info;
>  };
>
Hi Helin,

Just to check: Does this change affect the size of the structure and cause ABI
issues?

/Bruce