From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 6AE578D96
 for <dev@dpdk.org>; Mon,  2 Nov 2015 18:52:07 +0100 (CET)
Received: by pabfh17 with SMTP id fh17so30823793pab.0
 for <dev@dpdk.org>; Mon, 02 Nov 2015 09:52:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber_org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=2C8jcJsNJ0Cuk3mrRwi13j9EwNobHurBsHBHYElrW8o=;
 b=k8K0F/iwLWQaP180Tw76tJNgfXfg/hfaFJr/oqe0xSmYjdkGYh+TW1JyXFLNmTG4Vk
 ROXqMKTw7rVFcF5IhqZW1D0RG6RMN2nCoxotHaAyBspRLG1GNYF99BzkThmMW2IzFX+0
 oKQZDJ/tcRANIpUXHW8xkY4qBw0Fczeysk8Prs/ulMUc3TrWS0SkQ+KFqT0e1fVe6jlU
 2Y2bnDuWt52nwZ2gquSznMTBjia9uDjOkaitRNsNnsMVjf+ozzxiJBwIlDYM4/dcAHzo
 bh/7fWGSCCUcHdxOYcmKf6hPTOZZA0hssrODYQd8Dy90KK0s9SU5u4kJLJ/p5KifNBHM
 QjJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=2C8jcJsNJ0Cuk3mrRwi13j9EwNobHurBsHBHYElrW8o=;
 b=hKg88wq1cmVjgN3nEs4nAkwT2hG2EUQj+vJ9vZj94cl0Lm0+S1DJvKnEMpxB8ykuoR
 IxV7qIhlavp9NFTl3KleaX/N6qmdmauFEy4WDS6hofV68stcj0LKFzxWQ1oROfMuZjtG
 ka77PyKtmqRwG3hRJZLfJMe46i3JXZyBOizifkS9JRUbErvA0Y091iFwlMB8I6lxWnMc
 XV0PXvoTJaPyiESWFCzWpFaSB8RmFvmQoNlbzuBBajAD3+rlrUHgxeH4Z3srJHENYL5d
 DKcoINPfIk2anUeTryzAb+SZ0R8N2+pvDpUSKmK98eJ/dhGrxFmkq3svtqVnwq7V629U
 rTQQ==
X-Gm-Message-State: ALoCoQkPLBwYJ5nPlotCydXHH+DP4Sb/bQ957iXz76P8LueduiczBigNMQCyDtJ2LUO0aru5TMYS
X-Received: by 10.66.121.199 with SMTP id lm7mr28784789pab.30.1446486726757;
 Mon, 02 Nov 2015 09:52:06 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id xs2sm25123419pbb.75.2015.11.02.09.52.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 02 Nov 2015 09:52:06 -0800 (PST)
Date: Mon, 2 Nov 2015 09:52:17 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Message-ID: <20151102095217.7d40e38f@xeon-e3>
In-Reply-To: <1446231162-8075-10-git-send-email-adrien.mazarguil@6wind.com>
References: <1444067589-29513-1-git-send-email-adrien.mazarguil@6wind.com>
 <1446231162-8075-1-git-send-email-adrien.mazarguil@6wind.com>
 <1446231162-8075-10-git-send-email-adrien.mazarguil@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 09/13] mlx5: add link update device
 operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 17:52:07 -0000

On Fri, 30 Oct 2015 19:52:38 +0100
Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:

> +static int
> +mlx5_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete)
> +{
> +	struct priv *priv = dev->data->dev_private;
> +	struct ethtool_cmd edata = {
> +		.cmd = ETHTOOL_GSET
> +	};
> +	struct ifreq ifr;
> +	struct rte_eth_link dev_link;
> +	int link_speed = 0;
> +
> +	(void)wait_to_complete;

DPDK style is to use the __rte_unused attribute rather than dummy statements
to avoid unused warnings.