From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 03A0E8E9A for ; Mon, 2 Nov 2015 11:20:29 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 02 Nov 2015 02:20:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="840505953" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 02 Nov 2015 02:20:27 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id tA2AKRBe006100; Mon, 2 Nov 2015 10:20:27 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id tA2AKOsE011053; Mon, 2 Nov 2015 10:20:24 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id tA2AKNTU011049; Mon, 2 Nov 2015 10:20:23 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Mon, 2 Nov 2015 10:20:23 +0000 From: Ferruh Yigit To: Thomas Monjalon Message-ID: <20151102102023.GA29052@sivlogin002.ir.intel.com> Mail-Followup-To: Thomas Monjalon , dev@dpdk.org, Eric Kinzie References: <1706989.WgznurFLZ8@xps13> <4489406.qekDmzhmkY@xps13> <20151102000517.GA4669@sivlogin002.ir.intel.com> <4832819.EtRlJavyLu@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4832819.EtRlJavyLu@xps13> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 10:20:30 -0000 On Mon, Nov 02, 2015 at 08:10:25AM +0100, Thomas Monjalon wrote: > 2015-11-02 00:05, Ferruh Yigit: > > On Mon, Nov 02, 2015 at 12:24:51AM +0100, Thomas Monjalon wrote: > > > > ifeq ($(LINK_USING_CC),1) > > > > # Override the definition of LD here, since we're linking with CC > > > > LD := $(CC) $(CPU_CFLAGS) > > > > -O_TO_S = $(LD) $(call linkerprefix,$(CPU_LDFLAGS)) \ > > > > +O_TO_S = $(LD) $(call linkerprefix,$(SHARED_LDFLAGS)) \ > > > > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > > else > > > > -O_TO_S = $(LD) $(CPU_LDFLAGS) \ > > > > +O_TO_S = $(LD) $(SHARED_LDFLAGS) \ > > > > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > > endif > > > > > > Why do you remove CPU_LDFLAGS? > > > > CPU_LDFLAGS shared by other libraries and confilicts with this usage. > > Sorry I don't understand. > CPU_LDFLAGS is -melf_i386 for Intel 32-bit. > Why removing it for combined library? What is the conflict? When combined shared option enabled, CPP_LDFLAGS will be processed and other libraries CPU_LDFLAGS value will contain this value, and generate an compilation eroor like following: " gcc -m64 -Wl,--version-script=./lib/libdpdk.map -Wl,--version-script=/root/dpdk/lib/librte_eal/linuxapp/eal/rte_eal_version.map -shared -Wl,-soname,librte_eal.so.2.1 -o librte_eal.so.2.1 /usr/bin/ld: cannot open linker script file ./lib/libdpdk.map: No such file or directory collect2: error: ld returned 1 exit status " That is why I have created a new variable, and CPU_LDFLAGS was empty, but with double check what CPU_LDFLAGS is, it should stay there, I will update the patch, at worst I can add a new flag instead of replacing CPU_LDFLAGS Regards, ferruh