From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0060.outbound.protection.outlook.com [207.46.100.60]) by dpdk.org (Postfix) with ESMTP id 99B9F5949 for ; Mon, 2 Nov 2015 17:29:39 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.167.52.198) by CY1PR0701MB1978.namprd07.prod.outlook.com (10.163.141.20) with Microsoft SMTP Server (TLS) id 15.1.312.18; Mon, 2 Nov 2015 16:29:36 +0000 Date: Mon, 2 Nov 2015 21:59:12 +0530 From: Jerin Jacob To: "Hunt, David" Message-ID: <20151102162911.GC1869@localhost.localdomain> References: <1446212959-19832-1-git-send-email-david.hunt@intel.com> <1446212959-19832-2-git-send-email-david.hunt@intel.com> <20151102045728.GB16413@localhost.localdomain> <56375597.8070805@intel.com> <20151102125743.GA9506@localhost.localdomain> <5637809B.1000806@intel.com> <20151102163627.7a08bcc5@pcviktorin.fit.vutbr.cz> <563785FD.2080809@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <563785FD.2080809@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.52.198] X-ClientProxiedBy: MAXPR01CA0053.INDPRD01.PROD.OUTLOOK.COM (25.164.146.153) To CY1PR0701MB1978.namprd07.prod.outlook.com (25.163.141.20) X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1978; 2:b0cPLR+jhg4e4s6c6GT6YzpJr48SlYVXt0VER2hPImT6XroaqjnyLQ+k0B5gl1DJinLkx8XLXX5T8KCUEmvx7MwMejol1jJxL/bJOmWf3zLKL8wqo175/m37m6JmK9uNzWtkGFgbVTv/+gBA8mIx0ugV/RuckM4OWVj6YUjPQtM=; 3:Q4SjqbDp2RCSxPiMmNLibhTQ6k5r2mkdIqsGAp8VJvFi11WWlumfBjQy5e8sqyX5YmInZlwZQYATwlAUDc2k0pQsRvGT2L4qNR28MIcZ5ii5T8Ya3cJ9VJD8Q6HAxvTQNe5TOG0DKHP0Am/JnK7wtg==; 25:L8j8rQJ/wsO81oh3u7UUxUc1X3LK/uJFdsyhejI4uDaAE/hFwKhwHrGbPDIK7J2XeNeFIubn9G8Qe576TNXQjLIcANTwSZmsO1ZOQl1ThNXWKvSxAg5M3xkbS4jONxquPrzqDTnO+ACfXezNbE35sco7H6fsBG7rs1ar+un+sVoslYpG1s66KEbaETDmVXIN+ofmlpbwOphig8XZrz9d9gTdGAU8dX4LBVY9qmV7v6qlrY4v+li8W5L0yR2vSYBLgZjr7do+X94EiaF8Rj9wQg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1978; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1978; 20:VTALSXkq+P3SBtQMB6511lK1FFcT6ayNWZMNfBQULALRmQ3on2LhaaT6zMbs+TOla/r3uTJSFuQrmDgx65H9xVtSYXx2gvFwJXJAzQZGZjqFOe9iSXAcKRdnL/SQl6sfR8aJdfpLNOd3PhglRuhHG0VQGNxVbJ3pVGx/8WjmAGQp//y9f04BO9nxGJZZTmxRy3//IfiWK5W2EO0XrvoYGiGYmsmiI3q35nJj83Dg5J9X0N1Oaqu/vi0F1HGhcrf+byBxDwFzPoKje5Q67uyigWurRqWH6jh9PIKtMSN88WIfwbiy2Pf0OYWPEhZvu0ETjwNHio7mvNws493BpC8qp/Lbfx9YOawI8PnbFxUXm9VUSOYSV9k7Psbq4HuL+BAUoASDxayY6DZup3+oc0PxligatgCpfJ1WpZXup9P9aiN4lVENLZWgxAkf4SJ1YcRNH80lbOCGkjNte09mX3W0FGpH+U2hwLbx2fuMv8N4FkqDFeBygPcIQ5+Uvqp3bthQS/KNIkVSBzZcnEkNbKMF9Bbi9qopVfTbo+8+HL7eqUL/zhLv8/5+K2f2IHTSG6XGJyp/SqDJfOZg5KHQiL0ILrqKeb0CiiCN5gShEJslFoo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046); SRVR:CY1PR0701MB1978; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1978; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1978; 4:dIVMqVZ2gI/n0d2wdGfw9Oiv0h1u/8zrH1K/cRs1wRkU8wRgORcIQE3uBVBZrTNA4EYfueUMhMI3K+7jUCRc/4dI+2KcvscAAM+PnyF4OYQBOJ95U/el8iJr/tkiX+G4eCfxyh35f81+QBBbkVACfyr2oN9l/oMKseqT37AXZXdGJKfg4hI9qWFomtNDQeS70LIm0r2EaxHeCYDmawnWEyCQTLsdGbgX1v+XSAOBi1tUtE400Wc2zTuOD10Ma2otVPa3T0HlHHEgDZ7GEavdU2BnC6fplL/7Pou+DTL1WebxMCYRkpfhO1Kr9gMQDPj6EiOIJ7L5Vl0FXXiK/+z0gYaPZ2E8ZlxIHxDvHSnkMpJQs405hjMpGK4r5T6C+tVY X-Forefront-PRVS: 0748FF9A04 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(199003)(479174004)(164054003)(189002)(24454002)(47776003)(77096005)(83506001)(23726002)(86362001)(54356999)(87976001)(92566002)(76176999)(93886004)(50986999)(61506002)(101416001)(66066001)(189998001)(5007970100001)(110136002)(81156007)(5004730100002)(97736004)(40100003)(5008740100001)(4001350100001)(5001960100002)(42186005)(2950100001)(97756001)(46406003)(50466002)(106356001)(122386002)(33656002)(105586002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1978; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1978; 23:x7v5pTixI738AOtMFi1F6pSmlAHV7Eko3yQ9WXc?= =?us-ascii?Q?zeQu8eBuH+wTUfDdjUIFlQzRyI2h2AHgkoIPY6eDFgC6UmBgyWZPPtHAGCOZ?= =?us-ascii?Q?RLuDz8spByOib+ugk8hRLadNfdQITiERzFfdgVw0mb+SljmvwxmOrZJ1rEaF?= =?us-ascii?Q?tPkcQCRzjMtjaSHl6nm1gVDejmcE+xeZUUaLWqwsAw/DIhWLlXDsJpgYybbF?= =?us-ascii?Q?shYi7n0azcm8SrFIgauHCBdH1W5RYyNdT6Mrqxkt27RmLPSVdNMYMIVSFR5N?= =?us-ascii?Q?8WkVAuB94ishyaXv1zDHmzQNpRLWN65KQCJ1INZSS9qhuyb/3NeflgiXsIcK?= =?us-ascii?Q?eEH8e/aMYwxMWTMUy7bWmZ01ZW8Jam0seZiEvFD1KFv1Pgqnm7J/+bSpCbCu?= =?us-ascii?Q?jGMqqlvSK4OcqUU7heYoDpu0yS3SBSZXIRRw/0bY+/UZ5uXAJBv4xTWHyCoR?= =?us-ascii?Q?oQDIpTrBPKwFuvY/T5hiVH6fXF64LtblEH5muuc1JgxXu16BpTjyuL5Rcsuo?= =?us-ascii?Q?NqJCtOC/iSIO18slwTdRyjeXFPkiNYvrkE2/zMQdH8ymb2csJDPTWvyArjTW?= =?us-ascii?Q?YtbbU1Th4M1EGsNurWpT+AYwWUvLirPn5suat3M2EXbfsKqv3m2gWxOsnMEB?= =?us-ascii?Q?4ehv78zFx/Y0g+RiHkoXI+IqoJEEH4iULydDYmwK/IJZpsXF50D8xR5sD3Mf?= =?us-ascii?Q?+ZrUEh4HQRQGIAxQFVkWU/ibeDtGzoZYsZRoc68M56MaQSOqviktiyHBuPgx?= =?us-ascii?Q?rh3MBHceoNOSto9MURz8S2jY9ipamTJ1KgnRy96X/sIatn3dK/zaZAAOq8Cu?= =?us-ascii?Q?yeCkRB8xbsXRrGCQKmAOxsoGpnKkmyjaVj9OCYls3Pvxh/befHBRFoDWNHBE?= =?us-ascii?Q?xXdW2uom+sDZdxMRDLaF+LNLeJtrMT61qkEqK/Ga/PYmxbByK+38nkxoYyag?= =?us-ascii?Q?beNMdwn7p/vAEwnbiAFvdjoF5hPwsqLX+gliG+FCzZE4xJRxoTVfNVDQ7kIE?= =?us-ascii?Q?Ozsm+oX5ip1D3WIawmtXwWBLvWnRmrBXp3LP+9fqcxRC0iuDRJArU4qd4KxX?= =?us-ascii?Q?ou91YhE3fqf1oZglr58YvLtPncJ/V0dxIsLQ0n3gzJoTonv0xIQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1978; 5:6PObEFnOoJT380Z2g/lVI9vM0NMOyH3h7zi5kjjvXv1fGeqBm9gXZYK+iOQbqQRxmmtsYx/DTgZNZZlmpYASlNRDfrGik/ICCtCDeZI/xW/mSRvsSS/bLwaXt550jm61laZr3L5tZa1KnV2cNHKwXQ==; 24:TajO3s4Xk1bwXLYHuqW7td/G8bKxLLllplo7kpfi5q46tg1S9+rZZNnNIe5mnqszLWhDjQCjk3BdiXDF4Ju2+RzUUBoIxV/J3h/pZ7wM/AY=; 20:3bWBV4NnXUYl+kLRtmSwOPICcmv5WVz7V0VGaZSH+4CtoyHF3kXY05LkP0foWsQ/rvRg18vdMXs0SPfyhfD6yA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2015 16:29:36.4077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1978 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal/arm: add 64-bit armv8 version of rte_memcpy.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 16:29:40 -0000 On Mon, Nov 02, 2015 at 03:49:17PM +0000, Hunt, David wrote: > On 02/11/2015 15:36, Jan Viktorin wrote: > >On Mon, 2 Nov 2015 15:26:19 +0000 > --snip-- > >It was looking like we can share a lot of common code for both > >architectures. I didn't know how much different are the cpuflags. > > CPU flags for ARMv8 are looking like this now. Quite different to the ARMv7 > ones. > > static const struct feature_entry cpu_feature_table[] = { > FEAT_DEF(FP, 0x00000001, 0, REG_HWCAP, 0) > FEAT_DEF(ASIMD, 0x00000001, 0, REG_HWCAP, 1) > FEAT_DEF(EVTSTRM, 0x00000001, 0, REG_HWCAP, 2) > FEAT_DEF(AES, 0x00000001, 0, REG_HWCAP, 3) > FEAT_DEF(PMULL, 0x00000001, 0, REG_HWCAP, 4) > FEAT_DEF(SHA1, 0x00000001, 0, REG_HWCAP, 5) > FEAT_DEF(SHA2, 0x00000001, 0, REG_HWCAP, 6) > FEAT_DEF(CRC32, 0x00000001, 0, REG_HWCAP, 7) > FEAT_DEF(AARCH32, 0x00000001, 0, REG_PLATFORM, 0) > FEAT_DEF(AARCH64, 0x00000001, 0, REG_PLATFORM, 1) > }; > > >IMHO, it'd be better to have two directories arm and arm64. I thought > >to refer from arm64 to arm where possible. But I don't know whether is > >this possible with the DPDK build system. > > I think both methodologies have their pros and cons. However, I'd lean > towards the common directory with the "filename_32/64.h" scheme, as that > similar to the x86 methodology, and we don't need to tweak the include paths > to pull files from multiple directories. > I agree. Jan, could you please send the next version with filename_32/64.h for atomic and cpuflags(ie for all header files). I can re-base and send the complete arm64 patch based on your version. Thanks, Jerin > Dave >