From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3C9968E6E for ; Tue, 3 Nov 2015 10:20:37 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 03 Nov 2015 01:20:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,238,1444719600"; d="scan'208";a="825617089" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2015 01:20:34 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id tA39KXLq021179; Tue, 3 Nov 2015 09:20:33 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id tA39KX7b021598; Tue, 3 Nov 2015 09:20:33 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id tA39KX7R021594; Tue, 3 Nov 2015 09:20:33 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Tue, 3 Nov 2015 09:20:33 +0000 From: Ferruh Yigit To: Panu Matilainen Message-ID: <20151103092033.GA16414@sivlogin002.ir.intel.com> Mail-Followup-To: Panu Matilainen , dev@dpdk.org, Eric Kinzie References: <20151102102023.GA29052@sivlogin002.ir.intel.com> <1446477827-11541-1-git-send-email-ferruh.yigit@intel.com> <56385CDD.2030909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56385CDD.2030909@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH v2] mk: fix ABI versioning compile error for combined shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 09:20:37 -0000 On Tue, Nov 03, 2015 at 09:06:05AM +0200, Panu Matilainen wrote: > On 11/02/2015 05:23 PM, Ferruh Yigit wrote: >> Fixes following error: >> LD libdpdk.so >> /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found >> for symbol @DPDK_x.y >> >> Defines version symbols in a fixed path libdpdk.map file and this >> value hardcoded into makefile > > Hold on. What problem is this supposed to be fixing? This patch is to fix combined library compilation error when ABI versining used. Currently if ABI version macros used (VERSION_SYMBOL), we are not able to compile combined shared library. > If its for the bonding thing (as it'd appear from the threading), NAK. Nothing directly related to the bonding, just issue observed in this thread. > The symbol versioning in > that patch is confused needs to be fixed there instead of inventing strange > workarounds elsewhere. > This is not intented to be a workaround but a fix, unless you have a better idea. ferruh