From: Bruce Richardson <bruce.richardson@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] compile and install using configure-make-make_install
Date: Tue, 3 Nov 2015 10:16:53 +0000 [thread overview]
Message-ID: <20151103101653.GB15320@bricha3-MOBL3> (raw)
In-Reply-To: <563863D5.8010708@redhat.com>
On Tue, Nov 03, 2015 at 09:35:49AM +0200, Panu Matilainen wrote:
> On 10/27/2015 04:25 PM, Bruce Richardson wrote:
> >Just clarify a bit further the idea I had in mind, I've put together the following
> >two example patches. After applying these patches the following sequence of
> >operations works to install dpdk libraries and headers into /opt (/opt/lib/dpdk
> >and /opt/include/dpdk respectively). Also the machine type is changed from native
> >to default, and the settings for KNI are disabled.
> >
> > ./configure --prefix=/opt --machine=default \
> > --config=RTE_LIBRTE_KNI=n \
> > --config=CONFIG_RTE_KNI_KMOD=n
> > cd build
> > make
> > sudo make install
>
> I think I like the idea of a configure script that hides (some of) the DPDK
> config peculiarities behind a more familiar looking interface. For example
> it could be used for figuring out the machine-os-compiler triplet
> automatically for the common cases.
>
> However having "make install" behave differently depending on which
> directory its invoked from I dunno. Its unlike anything else out there (that
> I know of) and I thought the idea was to make DPDK behave more like a normal
> OSS citizen :)
>
> - Panu -
>
Yes, I would agree with your complaint.
Unfortunately, I can't see any quick-fix way for it in the short term. Ideally,
I think we should look to rename the existing "make install " option to something
else, and then later look to add in a proper make install like above.
For example: I would suggest in one release e.g. 2.2 to rename make install to
e.g. "make sdk" or "make target" [I like make target, since it implies that you
specify what the target should be with T="..."].
At that point, we add a new "make install" rule which simply prints out
"make install is deprecated, use 'make target' instead."
Then we wait a couple of releases to allow everyone to switch over to the new rule.
Once done, then we can look to introduce a new, more standard, "make install" type
target. [And in this case, I think limiting it to a build subdir or some such
would also be helpful, just to help those doing a multi-version upgrade jump]
/Bruce
next prev parent reply other threads:[~2015-11-03 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6594B51DBE477C48AAE23675314E6C460F1B724F@fmsmsx107.amr.corp.intel.com>
2015-10-20 9:17 ` [dpdk-dev] dpdk proposal installation process Bruce Richardson
2015-10-21 19:15 ` Olivier MATZ
2015-10-22 5:55 ` Panu Matilainen
2015-10-22 14:57 ` Bruce Richardson
2015-10-26 16:18 ` Arevalo, Mario Alfredo C
2015-10-27 14:25 ` [dpdk-dev] compile and install using configure-make-make_install Bruce Richardson
2015-10-27 14:25 ` [dpdk-dev] [RFC-PATCH 1/2] gen-build-mk: add "make install" option to build dir Bruce Richardson
2015-10-27 14:25 ` [dpdk-dev] [RFC-PATCH 2/2] add example configure script Bruce Richardson
2015-11-03 7:35 ` [dpdk-dev] compile and install using configure-make-make_install Panu Matilainen
2015-11-03 10:16 ` Bruce Richardson [this message]
2015-11-27 11:50 ` [dpdk-dev] dpdk proposal installation process Thomas Monjalon
2015-11-27 13:16 ` Marc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103101653.GB15320@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).