From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f47.google.com (mail-qg0-f47.google.com [209.85.192.47]) by dpdk.org (Postfix) with ESMTP id 547A38E98 for ; Tue, 3 Nov 2015 18:12:33 +0100 (CET) Received: by qgem9 with SMTP id m9so18532931qge.1 for ; Tue, 03 Nov 2015 09:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Ge0eirzbICCgIc2apYAWUw1Rh9tGHBbvX+vjoYbVssc=; b=YLSPKbLLx2pdGsk4MMf6VQKys/8BLQ5axFqaTtYtpIb6xXJ7gaLaCOY/pLfzsPf/Em D8yNOFZbDgXzhwPZvdxIaVV1mZrYkyTGC9HEmQaHgk988lrSB7y8dkw1grW30oOoLxL9 m1nW+kh4O7mouKB9bAFcvurRvaSoUnYh/eSi33tua3HHt5bGm5CAzwtAiFfCOXVzJwHi VbKWUBHHoQfVN5/A8nQvmltuYwug7UyS3j7yUJkJ9w5aA8wv+4ng97cxMZr/1J4RiSmd B8ULRt1pjksiWnjzVSTSc0EAfewZWDUP487YExKMQDg/19fllcZ1Tp4J5a9Fs8VQiiO2 BFeg== X-Received: by 10.140.128.16 with SMTP id 16mr39626826qha.54.1446570752855; Tue, 03 Nov 2015 09:12:32 -0800 (PST) Received: from gmail.com (pool-108-31-208-15.washdc.fios.verizon.net. [108.31.208.15]) by smtp.gmail.com with ESMTPSA id k201sm9962624qhc.34.2015.11.03.09.12.30 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Nov 2015 09:12:31 -0800 (PST) Received: by gmail.com (sSMTP sendmail emulation); Tue, 3 Nov 2015 12:12:30 -0500 Date: Tue, 3 Nov 2015 12:12:30 -0500 From: Eric Kinzie To: Panu Matilainen Message-ID: <20151103171228.GA5629@roosta.home> References: <1445268976-27491-1-git-send-email-ehkinzie@gmail.com> <20151102164206.GA14543@roosta.home> <563858B0.9010404@redhat.com> <20975652.eOFrqL9zPp@xps13> <563870C0.9090602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563870C0.9090602@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 17:12:33 -0000 On Tue Nov 03 10:30:56 +0200 2015, Panu Matilainen wrote: > On 11/03/2015 10:16 AM, Thomas Monjalon wrote: > >2015-11-03 08:48, Panu Matilainen: > >>On 11/02/2015 06:42 PM, Eric Kinzie wrote: > >>>On Mon Nov 02 12:23:47 +0200 2015, Panu Matilainen wrote: > >>>>On 11/01/2015 08:17 PM, Thomas Monjalon wrote: > >>>>>2015-10-19 08:36, Eric Kinzie: > >>>>>> Size of struct rte_eth_bond_8023ad_conf changed. Increment LIBABIVER > >>>>>> and version bond_mode_8023ad_setup and bond_mode_8023ad_conf_get > >>>>>> functions. > >>>>>[...] > >>>>>>+VERSION_SYMBOL(bond_mode_8023ad_setup, _v20, 2.0); > >>>>>[...] > >>>>>>+BIND_DEFAULT_SYMBOL(bond_mode_8023ad_setup, _v22, 2.2); > >>>>>>+MAP_STATIC_SYMBOL(void bond_mode_8023ad_setup(struct rte_eth_dev *dev, struct rte_eth_bond_8023ad_conf *conf), \ > >>>>>>+ bond_mode_8023ad_setup_v22); > >>>>> > >>>>>I'm sorry it doesn't work well when trying to build a combined lib: > >>>>> > >>>>>ld: libdpdk.so: version node not found for symbol bond_mode_8023ad_setup@@DPDK_2.2 > >>>>> > >>>>>The symbols are OK in the .o file: > >>>>>0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup@@DPDK_2.2 > >>>>>0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup@DPDK_2.0 > >>>>>0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup_v20 > >>>>>0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup_v22 > >>>>>0000000000000000 *UND* 0000000000000000 bond_mode_8023ad_setup > >>>>> > >>>>>I don't understand the problem and I am considering disabling versioning in > >>>>>combined library. > >>>>> > >>>>>Any idea? > >>>>> > >>>> > >>>>The .map additions look incorrect to me: > >>>> > >>>>>diff --git a/drivers/net/bonding/rte_eth_bond_version.map b/drivers/net/bonding/rte_eth_bond_version.map > >>>>>index 22bd920..7f78717 100644 > >>>>>--- a/drivers/net/bonding/rte_eth_bond_version.map > >>>>>+++ b/drivers/net/bonding/rte_eth_bond_version.map > >>>>>@@ -17,6 +17,9 @@ DPDK_2.0 { > >>>>> rte_eth_bond_slaves_get; > >>>>> rte_eth_bond_xmit_policy_get; > >>>>> rte_eth_bond_xmit_policy_set; > >>>>>+ rte_eth_bond_8023ad_ext_collect; > >>>>>+ rte_eth_bond_8023ad_ext_distrib; > >>>>>+ rte_eth_bond_8023ad_ext_slowtx; > >>>> > >>>>These symbols didn't exist in DPDK 2.0 but are only being added > >>>>here. So why are they being added to the 2.0 section? > >>> > >>>Yes, I think these should probably be moved. > >>> > >>> > >>>>> > >>>>> local: *; > >>>>>}; > >>>>>@@ -27,3 +30,10 @@ DPDK_2.1 { > >>>>> rte_eth_bond_free; > >>>>> > >>>>>} DPDK_2.0; > >>>>>+ > >>>>>+DPDK_2.2 { > >>>>>+ local > >>>>>+ > >>>>>+ bond_mode_8023ad_conf_get; > >>>>>+ bond_mode_8023ad_setup; > >>>>>+} DPDK_2.1; > >>>> > >>>>These are marked local, as in, "not exported" which doesn't seem > >>>>right. Also they're lacking the rte_eth_ prefix. AFAICS this is what > >>>>the symbol export map should look like here: > >>> > >>> > >>>These were not exported to begin with. But after versioning these > >>>functions, they are exported unless explicitly declared to be local here. > >>> > >> > >>And this does not ring any warning bells? :) > >> > >>Sorry, I was not looking at the patch as a whole. You're declaring these > >>symbols as exported with the versioning macros, eg > >> > >>BIND_DEFAULT_SYMBOL(bond_mode_8023ad_setup, _v22, 2.2); > >> > >>...and then explicitly telling it to not export them by declaring local, > >>and then we wonder why it has trouble finding the symbols. > >>The versioning macros wont invent the librte_ prefix for you, you need > >>to rename the functions accordingly. > >> > >>But all this versioning gymnastics is moot anyway because you declare > >>the ABI incompatible: > >> > >>-LIBABIVER := 1 > >>+LIBABIVER := 2 > >> > >>This changes the library soname, so no binary compiled against the > >>previous version can possibly use it anymore. As in, by definition there > >>can be no callers of the _v20 variants after this ABI version bump. > > > >Panu, thanks for your careful review. > >We must remove the private functions from the export map.and not bump LIBABIVER. > > > > Actually the LIBABIVER bump seems appropriate since a public struct > (rte_eth_bond_8023ad_conf) changes size. > > As for the rest, I'm not quite sure what the patch is trying to > achieve. I initially assumed its trying to add a new incompatible > version of rte_bond_mode_8023ad_setup() and > rte_eth_bond_8023ad_conf_get() which could be a perfectly reasonable > thing to do in some circumstances. As it is, the patch actually adds > versioning to an internal symbol which just doesn't make sense at > all. Symbol versioning is only meaningful for public symbols. > > - Panu - It's likely I misintepreted some advice from an ealier review of this code. The intention was to prevent an application accidentally reading/writing past the end of a struct rte_eth_bond_8023ad_conf after upgrading the library. I can send another version of these patches that, instead, adds new versions of rte_bond_mode_8023ad_setup() and rte_eth_bond_8023ad_conf_get(). Eric