From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
by dpdk.org (Postfix) with ESMTP id 3F9D08E6C
for <dev@dpdk.org>; Thu, 5 Nov 2015 17:51:27 +0100 (CET)
Received: by wmll128 with SMTP id l128so16649399wml.0
for <dev@dpdk.org>; Thu, 05 Nov 2015 08:51:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind_com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-type:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=sB6tEwvMYDOpcnk48tPhaMK+hcP5dpFpsa57PkdlRFM=;
b=VjzaCmHdb1i2U9U7W124Q+EsnVQsnEwGnGim0YobM+HPzIBLNejS6wdSC+5RvUTwnC
9RIqqSXSmM7KXtuIXfjXa6MDJ71ZWl8sCKOyAsY12qNWjTXZcnIGIoMsGKowXFFOoTV8
Hh8eEn/6/fLdDWB1wtd+w1qo1bn+Eidf5feDw0n+xp0ktDQS9KDifw1wMQaFg4wCVAnq
sv2NroUjUN30xjX3SuwgqImrir43ggGS7ONEta2MQQu5dT9qiySk26TFWoY/R31bYlJ8
NRsmthQp7sEN5Zadv9vrQpfLNkkfm4fk0yVb9oGFQQYIvDL/OaQYeTKbmz+iTEaDpJpI
TmRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-type:content-disposition
:content-transfer-encoding:in-reply-to:user-agent;
bh=sB6tEwvMYDOpcnk48tPhaMK+hcP5dpFpsa57PkdlRFM=;
b=IwlS1QR43C2HbYcgOrdHCTV916/M+wRXEoXcnPOk8Wt1TKF/cUt4WRDVG5ckV+BCVs
CJYlmRpBhyjnDyMJCRf8ETtGmoUhgkwOBq+3xh91zdloEr9BgEy0P/4L6YTWCVftBC0Z
YPUDfTHhD2lb54haAMO6fbPjOL2i+fL/hVaKzJCDFLK/kTnMLKoNxnBRtGyTaGmhopVq
/DUGmcLzRtJ+AqpqfSpz4OQmn7w7712aKvv+ttT38h+jdzMgLYGSVIjQJgTJpmH/DLD8
WgC3vPt/u8QQPSgTzo/J+pAAKTBYaVPImQabzjF90zyZMIlHOT1+ildCNPNpwYvssMXj
XSog==
X-Gm-Message-State: ALoCoQmZXd4BK1fzZ8D/QaudXZXLRsjiOwz7HT7pkJ96XxJlchxquf9LyNqafaIayYpIWCJKKAFp
X-Received: by 10.28.146.139 with SMTP id u133mr5180719wmd.56.1446742287044;
Thu, 05 Nov 2015 08:51:27 -0800 (PST)
Received: from autoinstall.dev.6wind.com
(guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177])
by smtp.gmail.com with ESMTPSA id os9sm7881792wjc.26.2015.11.05.08.51.25
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 05 Nov 2015 08:51:26 -0800 (PST)
Date: Thu, 5 Nov 2015 17:50:44 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: John McNamara <john.mcnamara@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20151105165044.GA18667@autoinstall.dev.6wind.com>
References: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size to
512
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Nov 2015 16:51:27 -0000
On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote:
> Increase commandline buffer size to 512 to allow for longer
> commandlines required by testpmd when dealing with flow
> director and IPv6 addresses.
>
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> ---
> lib/librte_cmdline/cmdline_rdline.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h
> index b9aad9b..72e2dad 100644
> --- a/lib/librte_cmdline/cmdline_rdline.h
> +++ b/lib/librte_cmdline/cmdline_rdline.h
> @@ -93,7 +93,7 @@ extern "C" {
> #endif
>
> /* configuration */
> -#define RDLINE_BUF_SIZE 256
> +#define RDLINE_BUF_SIZE 512
> #define RDLINE_PROMPT_SIZE 32
> #define RDLINE_VT100_BUF_SIZE 8
> #define RDLINE_HISTORY_BUF_SIZE BUFSIZ
> --
> 1.8.1.4
>
I have faced the same issue. For some commands this value is still too
low. For example, RETA update can not be used, the command line limits
he configuration to 34 entries.
See http://dpdk.org/ml/archives/dev/2015-October/024681.html
and particularly
http://dpdk.org/ml/archives/dev/2015-October/024682.html
It was too late to announce an ABI change so we left out the cmdline
size update.
Olivier, Thomas, what do you think about this? It seems this is really
blocking.
--
Nélio Laranjeiro
6WIND