From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id E3475591F
 for <dev@dpdk.org>; Mon,  9 Nov 2015 05:19:07 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 08 Nov 2015 20:19:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,265,1444719600"; d="scan'208";a="846366861"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by fmsmga002.fm.intel.com with ESMTP; 08 Nov 2015 20:19:06 -0800
Date: Mon, 9 Nov 2015 12:22:37 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Xiaobo Chi <xiaobo.chi@nokia.com>
Message-ID: <20151109042237.GK2326@yliu-dev.sh.intel.com>
References: <1446789877-11656-1-git-send-email-xiaobo.chi@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446789877-11656-1-git-send-email-xiaobo.chi@nokia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org, changchun.ouyang@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be
 specified
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2015 04:19:08 -0000

On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote:
>  eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading.

For such (fix) patch, I'd like to see what exact issue your patch fixes.

And if it fixes an issue, you'd better title your patch with something
like "vhost: fix ...", so that it's likely Thomas will put it into
high priority.

	--yliu

> 
> Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com>
> ---
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c
> index c54a938..4b05b5a 100644
> --- a/lib/librte_vhost/eventfd_link/eventfd_link.c
> +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c
> @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = {
>  
>  
>  static struct miscdevice eventfd_link_misc = {
> +	.minor = MISC_DYNAMIC_MINOR,
>  	.name = "eventfd-link",
>  	.fops = &eventfd_link_fops,
>  };
> -- 
> 1.9.4.msysgit.2