From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0
Date: Mon, 9 Nov 2015 21:55:47 +0200 [thread overview]
Message-ID: <20151109215105-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <2413695.XHLO16SCPC@xps13>
On Fri, Oct 30, 2015 at 06:48:09PM +0100, Thomas Monjalon wrote:
> 2015-10-18 10:04, Michael S. Tsirkin:
> > On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote:
> > > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote:
> > > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote:
> > > > > Make vhost-user virtio 1.0 compatible by adding it to the
> > > > > supported features and keeping the header length
> > > > > the same as for mergeable RX buffers.
> > > > >
> > > > > Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> > > >
> > > > Looks good to me
> > > >
> > > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > > >
> > > > Just one question: dpdk is only supported on little-endian
> > > > platforms at the moment, right?
> > >
> > > A recent release added in support for PPC (patches supplied by IBM). For
> > > example, see:
> > > http://dpdk.org/browse/dpdk/commit/?id=704ba3770032c5a901719d3837845581d5a56b58
> > >
> > > /Bruce
> >
> > This will require more work then as 1.0 is a different
> > endian-ness from 0.9. It's up to you guys to decide
> > whether correct BE support is now a requirement for all
> > new dpdk code. Let us know.
>
> I'm not sure to understand.
> Yes DPDK must work on big endian platforms.
> Does this patch prevent from using virtio 0.9 with big endian?
No it doesn't. virtio 0.9 with big endian most likely does not work
reliably with vhost-user at the moment since qemu does not tell vhost-user
about guest endian-ness (though it's common to have it match host,
then it will work by luck).
> Does it work with old QEMU not supporting virtio 1.0?
Yes it does.
virtio 1 requires a bunch of fields to be little endian.
If someone uses this patch with new QEMU on BE machine,
things won't work: you need
if (virtio_1)
cpu_to_le
On LE, cpu_to_le is a NOP so things work by luck.
In other words this patch is fine, more is needed to make virtio 1
work on BE hosts.
--
MST
next prev parent reply other threads:[~2015-11-09 19:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 11:08 Marcel Apfelbaum
2015-10-15 13:18 ` Michael S. Tsirkin
2015-10-16 2:24 ` Yuanhan Liu
2015-10-16 6:20 ` Michael S. Tsirkin
2015-10-16 7:43 ` Andriy Berestovskyy
2015-10-16 7:50 ` Yuanhan Liu
2015-10-16 7:56 ` Michael S. Tsirkin
2015-10-16 13:52 ` Bruce Richardson
2015-10-18 7:04 ` Michael S. Tsirkin
2015-10-30 17:48 ` Thomas Monjalon
2015-11-01 9:00 ` Marcel Apfelbaum
2015-11-01 9:53 ` Thomas Monjalon
2015-11-01 11:22 ` Marcel Apfelbaum
2015-11-09 19:55 ` Michael S. Tsirkin [this message]
2015-11-02 22:13 ` Thomas Monjalon
2015-11-03 3:45 ` Xu, Qian Q
2015-11-03 3:49 ` Xu, Qian Q
2015-11-03 8:03 ` Marcel Apfelbaum
2015-11-03 8:16 ` Xie, Huawei
2015-11-03 8:26 ` Thomas Monjalon
2015-11-03 8:30 ` Marcel Apfelbaum
2015-11-03 8:31 ` Marcel Apfelbaum
2015-10-16 6:39 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109215105-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=dev@dpdk.org \
--cc=marcel@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).