From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 072128DED for ; Tue, 10 Nov 2015 18:03:01 +0100 (CET) Received: by pasz6 with SMTP id z6so2264924pas.2 for ; Tue, 10 Nov 2015 09:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber_org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=AVLPNPVE18kOvo039l/f0fFO7MfONSN7HGrsbPOB8HU=; b=Y/jWirLevCgdBmVpSRS37fZNU8fROMgjkKnAaEbCNSJuWYQYNrwRFlWfCnaRywC9IP Utmn2TQFeL4jSZSfxSDbmKMSyCWoiidRXVHgESY5rwax/X6Q62AGgdDVHRBeJ4T1xEXi dzb2ioEhltku6TfqaiZWI+Vsgh5UxUhYYkAJ0KOhfUBO2sNl3jghjfP4R+VYVSN61Hl2 SBjgP7/dYO7EhgmSDu3te8Zy0HC7HWucqqVZmhg8TyAV/nr57ftV4BmSclwbMuscbwaY yHUudpz4IyGPoYEnZSQjmItQRIxk3Vgr9IGCtlpOtk+Mr6+9PHTTzicrcU6DLe0+ZmcM TQgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=AVLPNPVE18kOvo039l/f0fFO7MfONSN7HGrsbPOB8HU=; b=M5S9I77rCLs3L+vyRJqBnFmPSHCXs7j2hs9my6lYQMaw9Y6aOUImzGEL/j5UfxGauS Dktimk6HVWD4xfmPqbuSLkV0Q32yE/HWezX1wbCWZRCPrJMAL9h2ZslU4LgJes+9f+sn 97QedeiAO3roGoBcFSNC7+et0gCmJrwpR81uRhbPgj5E9xX/1cGj7TvK1PpbfrGFDZ72 5Fxzw46/Hm+8zWzZYFFLyNQEor8PWI1ARStUGETIUSNtlC5buo1BxtNDskPxhJHd+fO1 zBSc+utnEXHbNOvVBTkTstRE4SOietLFiMCv04cpzTiUUs3uRMNRJ1BwLZ/ZkE0K7lex 2mWQ== X-Gm-Message-State: ALoCoQlkzeMtDN6CZjM05PjhmEw9wQBREhfq1GZ8nzgoXNB8IPdrIItCndKMkjzr6oorupj3PtBT X-Received: by 10.68.139.98 with SMTP id qx2mr7289818pbb.150.1447174980366; Tue, 10 Nov 2015 09:03:00 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id hl2sm5076190pbb.58.2015.11.10.09.02.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 09:02:59 -0800 (PST) Date: Tue, 10 Nov 2015 09:03:09 -0800 From: Stephen Hemminger To: "Polehn, Mike A" Message-ID: <20151110090309.644517d5@xeon-e3> In-Reply-To: <745DB4B8861F8E4B9849C970520ABBF14975BCC7@ORSMSX102.amr.corp.intel.com> References: <745DB4B8861F8E4B9849C970520ABBF14975BCC7@ORSMSX102.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 17:03:01 -0000 On Tue, 10 Nov 2015 14:17:41 +0000 "Polehn, Mike A" wrote: > Adds ethdev driver prefetch of variable structure to CPU cache 0 > while calling into tx or rx device driver operation. > > RFC 2544 test of NIC task test measurement points show improvement > of lower latency and/or better packet throughput indicating clock > cycles saved. > > Signed-off-by: Mike A. Polehn Good idea, but lots of whitespace issues. Please also check your mail client.. ERROR: patch seems to be corrupt (line wrapped?) #80: FILE: lib/librte_ether/rte_ethdev.h:2457: , WARNING: please, no spaces at the start of a line #84: FILE: lib/librte_ether/rte_ethdev.h:2460: + int16_t nb_rx;$ WARNING: please, no spaces at the start of a line #89: FILE: lib/librte_ether/rte_ethdev.h:2462: + { /* limit scope of rxq variable */$ ERROR: code indent should use tabs where possible #90: FILE: lib/librte_ether/rte_ethdev.h:2463: + /* rxq is going to be immediately used, prefetch it */$ ERROR: code indent should use tabs where possible #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D dev->data->rx_queues[queue_id];$ WARNING: please, no spaces at the start of a line #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D dev->data->rx_queues[queue_id];$ ERROR: spaces required around that '=' (ctx:WxV) #91: FILE: lib/librte_ether/rte_ethdev.h:2464: + void *rxq =3D dev->data->rx_queues[queue_id]; ^ ERROR: code indent should use tabs where possible #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + rte_prefetch0(rxq);$ WARNING: Missing a blank line after declarations #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + void *rxq =3D dev->data->rx_queues[queue_id]; + rte_prefetch0(rxq); WARNING: please, no spaces at the start of a line #92: FILE: lib/librte_ether/rte_ethdev.h:2465: + rte_prefetch0(rxq);$ ERROR: code indent should use tabs where possible #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts);$ WARNING: please, no spaces at the start of a line #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts);$ WARNING: space prohibited between function name and open parenthesis '(' #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts); ERROR: spaces required around that '=' (ctx:WxV) #93: FILE: lib/librte_ether/rte_ethdev.h:2466: + nb_rx =3D (*dev->rx_pkt_burst)(rxq, rx_pkts, nb_pkts); ^ WARNING: please, no spaces at the start of a line #94: FILE: lib/librte_ether/rte_ethdev.h:2467: + }$ WARNING: please, no spaces at the start of a line #102: FILE: lib/librte_ether/rte_ethdev.h:2607: + void *txq;$ WARNING: please, no spaces at the start of a line #110: FILE: lib/librte_ether/rte_ethdev.h:2624: + txq =3D dev->data->tx_queues[queue_id];$ ERROR: spaces required around that '=' (ctx:WxV) #110: FILE: lib/librte_ether/rte_ethdev.h:2624: + txq =3D dev->data->tx_queues[queue_id]; ^ WARNING: please, no spaces at the start of a line #111: FILE: lib/librte_ether/rte_ethdev.h:2625: + rte_prefetch0(txq);$ WARNING: please, no spaces at the start of a line #113: FILE: lib/librte_ether/rte_ethdev.h:2627: + return (*dev->tx_pkt_burst)(txq, tx_pkts, nb_pkts);$ total: 8 errors, 12 warnings, 38 lines checked