From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EA4BB8D96 for ; Wed, 11 Nov 2015 09:23:07 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 11 Nov 2015 00:23:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="847723385" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga002.jf.intel.com with ESMTP; 11 Nov 2015 00:23:03 -0800 Date: Wed, 11 Nov 2015 16:26:57 +0800 From: Yuanhan Liu To: Jijiang Liu Message-ID: <20151111082657.GZ2326@yliu-dev.sh.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-4-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447224046-1169-4-git-send-email-jijiang.liu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 3/8] virtio/lib:add vhost TX checksum support capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 08:23:08 -0000 On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote: > Add vhost TX offload(CSUM and TSO) support capabilities. Claiming first that we support something, and then actually implementing in a later patch is wrong, as at this stage, we actually does not support that, hence, the functionality is broken. --yliu > > Signed-off-by: Jijiang Liu > --- > lib/librte_vhost/virtio-net.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index 14278de..81bd309 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -77,7 +77,11 @@ static struct virtio_net_config_ll *ll_root; > (VHOST_SUPPORTS_MQ) | \ > (1ULL << VIRTIO_F_VERSION_1) | \ > (1ULL << VHOST_F_LOG_ALL) | \ > - (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) > + (1ULL << VHOST_USER_F_PROTOCOL_FEATURES) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > + (1ULL << VIRTIO_NET_F_CSUM)) > + > static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; > > > -- > 1.7.7.6