From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 76058B62 for ; Wed, 11 Nov 2015 09:27:31 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 11 Nov 2015 00:27:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="598145917" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2015 00:27:24 -0800 Date: Wed, 11 Nov 2015 16:31:18 +0800 From: Yuanhan Liu To: Jijiang Liu , "Michael S. Tsirkin" Message-ID: <20151111083118.GA2326@yliu-dev.sh.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-8-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447224046-1169-8-git-send-email-jijiang.liu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 08:27:31 -0000 On Wed, Nov 11, 2015 at 02:40:45PM +0800, Jijiang Liu wrote: > Add virtio guest offload capabilities. > > Signed-off-by: Jijiang Liu > --- > lib/librte_vhost/virtio-net.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index 81bd309..839a333 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -80,7 +80,10 @@ static struct virtio_net_config_ll *ll_root; > (1ULL << VHOST_USER_F_PROTOCOL_FEATURES) | \ > (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > - (1ULL << VIRTIO_NET_F_CSUM)) > + (1ULL << VIRTIO_NET_F_CSUM) | \ > + (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ > + (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > + (1ULL << VIRTIO_NET_F_GUEST_TSO6)) I don't think we need that, and it might be wrong to set those fields at vhost. And, TBH, I am not 100% sure that I understand what those flags truely are and for. All I know is that they seem have something to do with QEMU/TAP device. Hopefully the virtio expert, Michael, could shine some lights on that. --yliu > > static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; > > -- > 1.7.7.6