From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8AAACB62
 for <dev@dpdk.org>; Wed, 11 Nov 2015 09:30:07 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 11 Nov 2015 00:30:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="817031804"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by orsmga001.jf.intel.com with ESMTP; 11 Nov 2015 00:30:07 -0800
Date: Wed, 11 Nov 2015 16:34:00 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Message-ID: <20151111083400.GB2326@yliu-dev.sh.intel.com>
References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com>
 <1447224046-1169-6-git-send-email-jijiang.liu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447224046-1169-6-git-send-email-jijiang.liu@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure
 defination
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2015 08:30:07 -0000

On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote:
> Remove the ip_hdr structure defination.

Even for such simple patch, you need state why. Stating that
"remove ip_hdr structure defination because we already have
that in rte_ip.h" will definitely let others to accept your
patch eaiser.

	--yliu
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
>  examples/vhost/main.c |   15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index c081b18..044c680 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -50,6 +50,7 @@
>  #include <rte_string_fns.h>
>  #include <rte_malloc.h>
>  #include <rte_virtio_net.h>
> +#include <rte_ip.h>
>  
>  #include "main.h"
>  
> @@ -292,20 +293,6 @@ struct vlan_ethhdr {
>  	__be16          h_vlan_encapsulated_proto;
>  };
>  
> -/* IPv4 Header */
> -struct ipv4_hdr {
> -	uint8_t  version_ihl;		/**< version and header length */
> -	uint8_t  type_of_service;	/**< type of service */
> -	uint16_t total_length;		/**< length of packet */
> -	uint16_t packet_id;		/**< packet ID */
> -	uint16_t fragment_offset;	/**< fragmentation offset */
> -	uint8_t  time_to_live;		/**< time to live */
> -	uint8_t  next_proto_id;		/**< protocol ID */
> -	uint16_t hdr_checksum;		/**< header checksum */
> -	uint32_t src_addr;		/**< source address */
> -	uint32_t dst_addr;		/**< destination address */
> -} __attribute__((__packed__));
> -
>  /* Header lengths. */
>  #define VLAN_HLEN       4
>  #define VLAN_ETH_HLEN   18
> -- 
> 1.7.7.6